Skip to content

Openreg: Add RNG Generator#138449

Closed
Zhenbin-8 wants to merge 1 commit intopytorch:mainfrom
Zhenbin-8:add_openreg_RNG
Closed

Openreg: Add RNG Generator#138449
Zhenbin-8 wants to merge 1 commit intopytorch:mainfrom
Zhenbin-8:add_openreg_RNG

Conversation

@Zhenbin-8
Copy link
Copy Markdown
Contributor

@Zhenbin-8 Zhenbin-8 commented Oct 21, 2024 •
edited
Loading

Implement RNG Generator by falling back to CPUGeneratorImpl.

cc @ezyang @albanD

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138449

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 1475c5c with merge base 33191bb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 21, 2024
@Zhenbin-8 Zhenbin-8 changed the title Openreg: Add RNG generator Openreg: Add RNG Generator Oct 21, 2024
@bdhirsh bdhirsh requested a review from albanD October 23, 2024 15:25
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2024
@Zhenbin-8
Copy link
Copy Markdown
Contributor Author

Zhenbin-8 commented Nov 19, 2024

@ezyang Would you please help take a look at this PR :)

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Nov 20, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 20, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Zhenbin-8
Copy link
Copy Markdown
Contributor Author

Zhenbin-8 commented Nov 20, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@Zhenbin-8
Openreg: Add RNG Generator (pytorch#138449)
acbd4b7 
Implement RNG Generator by falling back to CPUGeneratorImpl.

Pull Request resolved: pytorch#138449
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zhenbin-8 @ezyang @pytorchmergebot @bdhirsh @pytorchbot