Skip to content

add CUDA 12.6 to conda docker image#138417

Closed
tinglvv wants to merge 1 commit intopytorch:mainfrom
tinglvv:cuda_12.6.2_conda_docker
Closed

add CUDA 12.6 to conda docker image#138417
tinglvv wants to merge 1 commit intopytorch:mainfrom
tinglvv:cuda_12.6.2_conda_docker

Conversation

@tinglvv
Copy link
Copy Markdown
Collaborator

@tinglvv tinglvv commented Oct 20, 2024

Adds cuda 12.6 to common installation script.
Adds cuda 12.6 to conda docker image build matrix.

related to #138440

cc @atalman @ptrblck @nWEIdia

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Oct 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138417

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5110bc6 with merge base f568d48 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 20, 2024
@tinglvv tinglvv changed the title 12.6 conda docker image [cuda upgrade] add CUDA 12.6 to conda docker image Oct 20, 2024
@tinglvv tinglvv changed the title [cuda upgrade] add CUDA 12.6 to conda docker image add CUDA 12.6 to conda docker image Oct 21, 2024
Copy link
Copy Markdown
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try removing install_121 in install_cuda.sh

@tinglvv tinglvv marked this pull request as ready for review October 22, 2024 22:36
@tinglvv tinglvv requested review from a team and jeffdaily as code owners October 22, 2024 22:36
@tinglvv
Copy link
Copy Markdown
Collaborator Author

tinglvv commented Oct 22, 2024

We should try removing install_121 in install_cuda.sh

good point, let's do that in a separate deprecation PR.

Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Oct 23, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
Adds cuda 12.6 to common installation script.
Adds cuda 12.6 to conda docker image build matrix.

fixes #138440

Pull Request resolved: #138417
Approved by: https://github.com/cyyever, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants