[PyTorch] Hook up fp16_gemv_trans to gemv fast path for non-aarch64 architectures#138005
Closed
swolchok wants to merge 12 commits intogh/swolchok/667/basefrom
Closed
[PyTorch] Hook up fp16_gemv_trans to gemv fast path for non-aarch64 architectures#138005swolchok wants to merge 12 commits intogh/swolchok/667/basefrom
swolchok wants to merge 12 commits intogh/swolchok/667/basefrom
Conversation
…rchitectures Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138005
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0bd8d1f with merge base 86602a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 15, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
swolchok
added a commit
that referenced
this pull request
Oct 15, 2024
…rchitectures Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) ghstack-source-id: 248140851 Pull Request resolved: #138005
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
swolchok
added a commit
that referenced
this pull request
Oct 24, 2024
…rchitectures Pull Request resolved: #138005 Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. ghstack-source-id: 249911241 @exported-using-ghexport Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/)
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 28, 2024
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
This was referenced Oct 29, 2024
malfet
approved these changes
Oct 31, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
Sure, but we should have half_one and half_zero constants somewhere to avoid doing casts all the time
Comment on lines
+305
to
+306
| alpha.x == fp16_ieee_from_fp32_value(1.0f) && | ||
| beta.x == fp16_ieee_from_fp32_value(0.0f); |
Contributor
There was a problem hiding this comment.
fp16_ieee_from_fp32_value calls are very slow, but we have one and zero constants, don't we?
Contributor
Author
There was a problem hiding this comment.
fp16_ieee_from_fp32_value calls are very slow
above comment demonstrates it's constant-foldable
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
…n-aarch64 architectures" Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64351092 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: #138275 Approved by: https://github.com/malfet ghstack dependencies: #139082, #139083, #137918, #138005
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
…rchitectures (pytorch#138005) Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv. Differential Revision: [D64351092](https://our.internmc.facebook.com/intern/diff/D64351092/) Pull Request resolved: pytorch#138005 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918
rahulsingh-intel
pushed a commit
to rahulsingh-intel/pytorch
that referenced
this pull request
Nov 5, 2024
No real reason to have the zero-beta restriction, so let's lift it. Testing: intentionally broke new paths locally to verify test coverage existed Differential Revision: [D64407752](https://our.internmc.facebook.com/intern/diff/D64407752/) Pull Request resolved: pytorch#138275 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139082, pytorch#139083, pytorch#137918, pytorch#138005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Following up on previous rev to use fp16_gemv_trans in gemv, not just gemm-used-for-gemv.
Differential Revision: D64351092