[PyTorch] add NEON half2float fmadd/fmsub#137723
Closed
swolchok wants to merge 4 commits intogh/swolchok/653/basefrom
Closed
[PyTorch] add NEON half2float fmadd/fmsub#137723swolchok wants to merge 4 commits intogh/swolchok/653/basefrom
swolchok wants to merge 4 commits intogh/swolchok/653/basefrom
Conversation
NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137723
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit de8a7a9 with merge base de4c2a3 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64197048 |
This was referenced Oct 10, 2024
NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64197048 |
NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64197048 |
swolchok
added a commit
that referenced
this pull request
Oct 10, 2024
Pull Request resolved: #137723 NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. ghstack-source-id: 247383137 @exported-using-ghexport Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/)
…d/fmsub" NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64197048 |
swolchok
added a commit
that referenced
this pull request
Oct 10, 2024
Pull Request resolved: #137723 NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface. ghstack-source-id: 247393404 @exported-using-ghexport Differential Revision: [D64197048](https://our.internmc.facebook.com/intern/diff/D64197048/)
jgong5
approved these changes
Oct 11, 2024
Contributor
Author
|
this is getting folded into a forthcoming PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
defined(__aarch64__) && !defined(CPU_CAPABILITY_SVE256)instead ofdefined(CPU_CAPABILITY_NEON)#137722NEON supports this (FMLAL/FMLAL2)and our FP16 GEMV fast path uses it. Add it as a supported Vectorized interface.
Differential Revision: D64197048
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10