Skip to content

Fixes the manylinux_2_28 docker image to build PyTorch on Aarch64#137696

Closed
gausah01 wants to merge 1 commit intopytorch:mainfrom
gausah01:work_gcc
Closed

Fixes the manylinux_2_28 docker image to build PyTorch on Aarch64#137696
gausah01 wants to merge 1 commit intopytorch:mainfrom
gausah01:work_gcc

Conversation

@gausah01
Copy link
Contributor

@gausah01 gausah01 commented Oct 10, 2024 •
edited
Loading

This change provides the openblas support to the Docker image manylinux_2_28.

  • It allows us to build pytorch using manylinux_2_28.
  • Using this image in PyTorch builds provides the major perf improvements when tested torch bench models.

@gausah01 gausah01 requested a review from jeffdaily as a code owner October 10, 2024 14:50
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 10, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137696

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit dc2f3bc with merge base 575f260 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ezyang ezyang requested a review from malfet October 11, 2024 01:20
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 11, 2024
@snadampal snadampal self-requested a review October 15, 2024 14:29
@jondea jondea mentioned this pull request Nov 8, 2024
Closed
@gausah01 gausah01 changed the title Provide Openblas support to the Docker image with GCC 11 Provide Openblas support to the Docker image with GCC 11 for building PyTorch using manylinux_2_28 Nov 8, 2024
@gausah01 gausah01 changed the title Provide Openblas support to the Docker image with GCC 11 for building PyTorch using manylinux_2_28 Fixes the manylinux_2_28 docker image to build PyTorch on Aarch64 Nov 8, 2024
atalman
atalman approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Nov 14, 2024

@pytorchbot merge -f "Required fix, all jobs are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 14, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@gausah01
Fixes the manylinux_2_28 docker image to build PyTorch on Aarch64 (py…
3b34c01 
…torch#137696)

This change provides the openblas support to the Docker image manylinux_2_28.

- It allows us to build pytorch using manylinux_2_28.
- Using this image in PyTorch builds  provides the major perf improvements when tested torch bench models.

Pull Request resolved: pytorch#137696
Approved by: https://github.com/snadampal, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@snadampal snadampal snadampal approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gausah01 @atalman @pytorchmergebot @snadampal @ezyang @pytorchbot