[AMD] Unify cublaslt and hipblaslt path#137604
Closed
xw285cornell wants to merge 1 commit intopytorch:mainfrom
Closed
[AMD] Unify cublaslt and hipblaslt path#137604xw285cornell wants to merge 1 commit intopytorch:mainfrom
xw285cornell wants to merge 1 commit intopytorch:mainfrom
Conversation
Differential Revision: D63967918
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137604
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d5f2e7e with merge base b71d0ac ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63967918 |
eqy
approved these changes
Oct 9, 2024
Collaborator
|
@pytorchbot label "topic: not user facing" |
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Oct 17, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 20, 2024
Fixes #138067 A partial reversion of this PR: #137604 The breakage is on AMD GPUs that do not fully support hipBLASLt, e.g. gfx1100 Pull Request resolved: #138267 Approved by: https://github.com/malfet
pytorchmergebot
added a commit
that referenced
this pull request
Oct 21, 2024
This reverts commit 14a3e12. Reverted #138267 on behalf of https://github.com/jeffdaily due to this PR went to far when partially reverting #137604; the env var default should be the same on ROCm and CUDA ([comment](#138267 (comment)))
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 28, 2024
Fixes #138067 A partial reversion of this PR: #137604 The breakage is on AMD GPUs that do not fully support hipBLASLt, e.g. gfx1100 Pull Request resolved: #138267 Approved by: https://github.com/eqy, https://github.com/jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D63967918