Implement unsqueeze for sparse vectors (this also makes stack work out of the box)#13760
Closed
umanwizard wants to merge 3 commits intopytorch:masterfrom
Closed
Implement unsqueeze for sparse vectors (this also makes stack work out of the box)#13760umanwizard wants to merge 3 commits intopytorch:masterfrom
unsqueeze for sparse vectors (this also makes stack work out of the box)#13760umanwizard wants to merge 3 commits intopytorch:masterfrom
Conversation
weiyangfb
reviewed
Nov 13, 2018
aten/src/ATen/native/TensorShape.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
weiyangfb
approved these changes
Nov 13, 2018
Contributor
weiyangfb
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! LGTM with minor nits.
14 tasks
Contributor
|
|
7532b3b to
f06e722
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 14, 2018
…k out of the box) Summary: Pull Request resolved: pytorch/pytorch#13760 Differential Revision: D13065342 Pulled By: umanwizard fbshipit-source-id: a5e2e80f87ffbbfdf8759b1b593ef34d290ae907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.