Fix rendezvous error due to EtcdStore get method not waiting in some cases#137056
Closed
alenawang wants to merge 2 commits intopytorch:mainfrom
Closed
Fix rendezvous error due to EtcdStore get method not waiting in some cases#137056alenawang wants to merge 2 commits intopytorch:mainfrom
alenawang wants to merge 2 commits intopytorch:mainfrom
Conversation
Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137056
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit af29007 with merge base c07ebaf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XilunWu
reviewed
Oct 1, 2024
Contributor
XilunWu
left a comment
There was a problem hiding this comment.
The PR looks good to me except some suggestions on lint. Thanks for the fix!!
test/distributed/elastic/rendezvous/etcd_rendezvous_backend_test.py
Outdated
Show resolved
Hide resolved
Contributor
Author
@XilunWu Thank you! Apologies for missing the linter instructions - I ran the linter locally and fixed the issues it was complaining about. |
fduwjj
approved these changes
Oct 1, 2024
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
…cases (pytorch#137056) Fixes pytorch#132950 This fixes an issue in `torch/distributed/elastic/rendezvous/etcd_store.py` where the [get method](https://github.com/pytorch/pytorch/blob/v2.4.0/torch/distributed/elastic/rendezvous/etcd_store.py#L60) does not wait as expected when no keys have been written under the store prefix yet (and therefore the store prefix key does not exist). This was because the `_try_wait_get` method would error out immediately [here](https://github.com/alenawang/pytorch/blob/main/torch/distributed/elastic/rendezvous/etcd_store.py#L179) if the prefix was not found instead of continuing to the etcd watch. This was causing upstream issues where distributed jobs using etcd-v2 could not get past the initial rendezvous at all (details in issue pytorch#132950). We added a test demonstrating this issue and the fix. Without the fix the test fails with `etcd.EtcdKeyNotFound: Key not found : /torch/elastic/store` instead of waiting for the first key to be written; with the fix the test waits properly. Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> Pull Request resolved: pytorch#137056 Approved by: https://github.com/fduwjj Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132950
This fixes an issue in
torch/distributed/elastic/rendezvous/etcd_store.pywhere the get method does not wait as expected when no keys have been written under the store prefix yet (and therefore the store prefix key does not exist). This was because the_try_wait_getmethod would error out immediately here if the prefix was not found instead of continuing to the etcd watch.This was causing upstream issues where distributed jobs using etcd-v2 could not get past the initial rendezvous at all (details in issue #132950).
We added a test demonstrating this issue and the fix. Without the fix the test fails with
etcd.EtcdKeyNotFound: Key not found : /torch/elastic/storeinstead of waiting for the first key to be written; with the fix the test waits properly.Co-authored-by: tarat44 32471142+tarat44@users.noreply.github.com
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o