[inductor] modify the heuristic for disabling vectorization#136422
Closed
jiayisunx wants to merge 7 commits intogh/jiayisunx/31/basefrom
Closed
[inductor] modify the heuristic for disabling vectorization#136422jiayisunx wants to merge 7 commits intogh/jiayisunx/31/basefrom
jiayisunx wants to merge 7 commits intogh/jiayisunx/31/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136422
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a6ee95b with merge base d2ec289 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
leslie-fang-intel
approved these changes
Oct 8, 2024
jgong5
approved these changes
Oct 9, 2024
| ] | ||
| ) | ||
| and group[tiling_indices[0]] < tiling_factor / 2 | ||
| and group[tiling_indices[0]] < tiling_factor / 4 |
Collaborator
There was a problem hiding this comment.
Please add code comment on this heuristics explaining why we set things like that.
Collaborator
Author
There was a problem hiding this comment.
Added, thanks for your comments!
jiayisunx
added a commit
to jiayisunx/pytorch
that referenced
this pull request
Oct 21, 2024
ghstack-source-id: ee9254f Pull Request resolved: pytorch#136422
jansel
approved these changes
Nov 4, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Since we have already implemented tail loop mask vectorization (#126526), I re-tuned the heuristics for disabling vectorization from performance perspective. I changed the heuristic to: when the total number of elements along the vec dim is less than
tiling_factor/4and the number of operations is less than 10, we disable the vectorization.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov