fix mypi in utils/_sympy/functions.py by bobrenjc93 · Pull Request #136339 · pytorch/pytorch

bobrenjc93 · 2024-09-19T22:56:20Z

Stack from ghstack (oldest at bottom):

Signed-off-by: Bob Ren bobren@fb.com

Turns out older versions of python, in particular 3.8 shows errors that 3.12 doesn't. For posterity these are the steps I took to reproduce:

conda create -n py38 python=3.8
conda activate py38
pip install -r requirements.txt
lintrunner init
dmypy restart && lintrunner --all-files --take MYPY

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

Signed-off-by: Bob Ren <bobren@fb.com> [ghstack-poisoned]

pytorch-bot · 2024-09-19T22:56:23Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136339

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 34afab4 with merge base 7755176 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 2, 3, linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.9-clang10 / test (dynamo, 1, 3, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 1, 5, lf.linux.4xlarge.nvidia.gpu) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_AVX512, 1, 2, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_NO_AVX2, 2, 2, lf.linux.2xlarge) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (disabled by #128551 but the issue was closed recently and a rebase is needed to make it pass)
test_dataloader.py::TestDataLoader::test_segfault

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Bob Ren <bobrenfb.com> Turns out older versions of python, in particular 3.8 shows errors that 3.12 doesn't. I managed to fix all the type errors except one. ``` (py38) [15:48] devvm1521:/home/bobren/local/pytorch dmypy check torch/utils/_sympy/functions.py torch/utils/_sympy/functions.py:1159:5: error: Signature of "__repr__" incompatible with supertype "Printable" [override] torch/utils/_sympy/functions.py:1159:5: note: Superclass: torch/utils/_sympy/functions.py:1159:5: note: def __str__(Printable, /) -> Any torch/utils/_sympy/functions.py:1159:5: note: Subclass: torch/utils/_sympy/functions.py:1159:5: note: def __repr__(self) -> Any ``` I don't really understand the error. I looked in both our codebase and sympy's codebase for `def __str__(Printable` and couldn't find it. cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]

Signed-off-by: Bob Ren <bobrenfb.com> Turns out older versions of python, in particular 3.8 shows errors that 3.12 doesn't. For posterity these are the steps I took to reproduce: ``` conda create -n py38 python=3.8 conda activate py38 pip install -r requirements.txt lintrunner init dmypy restart && lintrunner --all-files --take MYPY ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]

Signed-off-by: Bob Ren <bobrenfb.com> Turns out older versions of python, in particular 3.8 shows errors that 3.12 doesn't. For posterity these are the steps I took to reproduce: ``` conda create -n py38 python=3.8 conda activate py38 pip install -r requirements.txt lintrunner init dmypy restart && lintrunner --all-files --take MYPY ``` [ghstack-poisoned]

Signed-off-by: Bob Ren <bobrenfb.com> ghstack-source-id: 1d26a6b Pull Request resolved: #136339

bobrenjc93 · 2024-09-20T16:19:00Z

@pytorchbot merge

pytorchmergebot · 2024-09-20T16:20:50Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Skylion007 · 2024-09-20T16:23:02Z

FYI, I think these are issues with invalidation in dmypy cache and not related to different Python versions.

aorenste · 2024-09-20T16:24:49Z

FYI, I think these are issues with invalidation in dmypy cache and not related to different Python versions.

He specifically tried "dmypy restart" and still didn't get the errors until he switched python versions.

Revert "[PT2][Inductor][Optmus] fix test_pad_mm_bf16 and reland to fix long computation kernel (#136349)" This reverts commit e184391. Revert "Fix clang-tidy warnings in torch/csrc/lazy (#134655)" This reverts commit 0287146. Revert "Remove duplicate line (#136383)" This reverts commit 0b91e7e. Revert "[TF32] Account for TF32 in `test_conv_double_backward` (#135716)" This reverts commit 29f7b8d. Revert "Fix `Vectorized<double>::next_after` SVE compilation (#136388)" This reverts commit 7936584. Revert "Upgrade pybind11 API calls for 3.13t (#136370)" This reverts commit 067d203. Revert "[AOTI][Tooling] Filter out kernels based off lowercase names (#135395)" This reverts commit 1a10751. Revert "Add decomps for max_unpool (#133146)" This reverts commit 0c936c3. Revert "add TORCH_CUDA_CPP_API for AutoNcclGroup (#130012)" This reverts commit 293fccf. Revert "Use cpython declaration of _PyWeakref_ClearRef (#136300)" This reverts commit d2455b9. Revert "fix mypi in utils/_sympy/functions.py (#136339)" This reverts commit 7f9c064. Revert "[Inductor] Fix test_profiler_mark_wrapper_call_cuda_cuda_wrapper (#136356)" This reverts commit f53a0f9. Revert "Add more distributed examples (#130427)" This reverts commit 5997354. Revert "return instead of using skipTest (#136244)" This reverts commit 29affa6. Reapply "[PT2/Profiler] Add Context Info to Torch-Compiled Regions (#132765)" This reverts commit 783c5ba. Revert "Enable torch build with SLEEF on ARM by default (#133339)" This reverts commit 4842f0f. Revert "[inductor] Relax the conditions for loop split (#135335)" This reverts commit 687e5cf. [ghstack-poisoned]

Revert "[PT2][Inductor][Optmus] fix test_pad_mm_bf16 and reland to fix long computation kernel (#136349)" This reverts commit e184391. Revert "Fix clang-tidy warnings in torch/csrc/lazy (#134655)" This reverts commit 0287146. Revert "Remove duplicate line (#136383)" This reverts commit 0b91e7e. Revert "[TF32] Account for TF32 in `test_conv_double_backward` (#135716)" This reverts commit 29f7b8d. Revert "Fix `Vectorized<double>::next_after` SVE compilation (#136388)" This reverts commit 7936584. Revert "Upgrade pybind11 API calls for 3.13t (#136370)" This reverts commit 067d203. Revert "[AOTI][Tooling] Filter out kernels based off lowercase names (#135395)" This reverts commit 1a10751. Revert "Add decomps for max_unpool (#133146)" This reverts commit 0c936c3. Revert "add TORCH_CUDA_CPP_API for AutoNcclGroup (#130012)" This reverts commit 293fccf. Revert "Use cpython declaration of _PyWeakref_ClearRef (#136300)" This reverts commit d2455b9. Revert "fix mypi in utils/_sympy/functions.py (#136339)" This reverts commit 7f9c064. Revert "[Inductor] Fix test_profiler_mark_wrapper_call_cuda_cuda_wrapper (#136356)" This reverts commit f53a0f9. Revert "Add more distributed examples (#130427)" This reverts commit 5997354. Revert "return instead of using skipTest (#136244)" This reverts commit 29affa6. Reapply "[PT2/Profiler] Add Context Info to Torch-Compiled Regions (#132765)" This reverts commit 783c5ba. Revert "Enable torch build with SLEEF on ARM by default (#133339)" This reverts commit 4842f0f. Revert "[inductor] Relax the conditions for loop split (#135335)" This reverts commit 687e5cf. ghstack-source-id: b0fb91e Pull Request resolved: #136668

fix mypi in utils/_sympy/functions.py

432a627

Signed-off-by: Bob Ren <bobren@fb.com> [ghstack-poisoned]

pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Sep 19, 2024

bobrenjc93 requested a review from aorenste September 19, 2024 22:56

bobrenjc93 added the topic: not user facing topic category label Sep 19, 2024

bobrenjc93 marked this pull request as ready for review September 19, 2024 23:38

bobrenjc93 added a commit that referenced this pull request Sep 19, 2024

fix mypi in utils/_sympy/functions.py

4b6c837

Signed-off-by: Bob Ren <bobrenfb.com> ghstack-source-id: 1d26a6b Pull Request resolved: #136339

Skylion007 approved these changes Sep 20, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2024

pytorchmergebot added the merging label Sep 20, 2024

pytorchmergebot added the Merged label Sep 20, 2024

pytorchmergebot closed this in 7f9c064 Sep 20, 2024

pytorchmergebot removed the merging label Sep 20, 2024

zou3519 mentioned this pull request Sep 25, 2024

Revert a bunch of stuff #136668

Closed

github-actions bot deleted the gh/bobrenjc93/18/head branch October 21, 2024 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix mypi in utils/_sympy/functions.py#136339

fix mypi in utils/_sympy/functions.py#136339
bobrenjc93 wants to merge 5 commits intogh/bobrenjc93/18/basefrom
gh/bobrenjc93/18/head

bobrenjc93 commented Sep 19, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

bobrenjc93 commented Sep 20, 2024

Uh oh!

pytorchmergebot commented Sep 20, 2024

Uh oh!

Skylion007 commented Sep 20, 2024

Uh oh!

aorenste commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bobrenjc93 commented Sep 19, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136339

✅ You can merge normally! (8 Unrelated Failures)

Uh oh!

bobrenjc93 commented Sep 20, 2024

Uh oh!

pytorchmergebot commented Sep 20, 2024

Merge started

Uh oh!

Skylion007 commented Sep 20, 2024

Uh oh!

aorenste commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bobrenjc93 commented Sep 19, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 19, 2024 •

edited

Loading