Skip to content

Check argument types in 'checkTypes'#1363

Merged
colesbury merged 1 commit intopytorch:masterfrom
colesbury:checkTypes
Apr 26, 2017
Merged

Check argument types in 'checkTypes'#1363
colesbury merged 1 commit intopytorch:masterfrom
colesbury:checkTypes

Conversation

@colesbury
Copy link
Copy Markdown
Member

Fixes #1357

@apaszke
Copy link
Copy Markdown
Contributor

apaszke commented Apr 26, 2017

It'd be the best to use THPUtils_invalidArguments so we have consistent error messages between nn modules, but that's ok too I guess.

@colesbury
Copy link
Copy Markdown
Member Author

The problem is that this file specifically doesn't depend on the Python API, but THPUtils_invalidArguments does.

@colesbury colesbury merged commit 8ca7bf2 into pytorch:master Apr 26, 2017
@colesbury colesbury deleted the checkTypes branch April 26, 2017 19:28
Jiaming-Liu pushed a commit to Jiaming-Liu/pytorch that referenced this pull request May 18, 2017
eqy pushed a commit to eqy/pytorch that referenced this pull request Jan 20, 2022
jagadish-amd pushed a commit to jagadish-amd/pytorch that referenced this pull request Sep 5, 2024
[release/2.2] Cherry-picking few local changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants