Skip to content

[DSD][EZ] Minor update in _state_dict_utils.py#136165

Closed
wz337 wants to merge 1 commit intogh/wz337/31/basefrom
gh/wz337/31/head
Closed

[DSD][EZ] Minor update in _state_dict_utils.py#136165
wz337 wants to merge 1 commit intogh/wz337/31/basefrom
gh/wz337/31/head

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Sep 16, 2024 •
edited by pytorch-bot bot
Loading

@wz337
Update
fc0c2df 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Sep 16, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136165

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit fc0c2df with merge base 011cae9 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wz337 added a commit that referenced this pull request Sep 16, 2024
@wz337
minor update
8e926a8 
ghstack-source-id: bb81b08
Pull Request resolved: #136165
@wz337 wz337 changed the title minor update [DSD][EZ] Minor update in _state_dict_utils.py Sep 16, 2024
@wz337 wz337 requested a review from fegin September 16, 2024 20:11
@wz337 wz337 added the topic: not user facing topic category label Sep 16, 2024
kwen2501
kwen2501 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More readable!

@wz337
Copy link
Contributor Author

wz337 commented Sep 17, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 17, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@wz337
Copy link
Contributor Author

wz337 commented Sep 17, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 17, 2024

Merge started

Your change will be merged while ignoring the following 3 checks: Lint / lintrunner-noclang / linux-job, pull / linux-docs / build-docs-python-false, pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@wz337 @Chao1Han
[DSD][EZ] Minor update in _state_dict_utils.py (pytorch#136165)
bec3669 
Pull Request resolved: pytorch#136165
Approved by: https://github.com/kwen2501
ghstack dependencies: pytorch#135725, pytorch#135763
@github-actions github-actions bot deleted the gh/wz337/31/head branch October 18, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wz337 @pytorchmergebot @kwen2501