[Distributed] add FP8 support to NaN checker#135891
Closed
kwen2501 wants to merge 2 commits intogh/kwen2501/59/basefrom
Closed
[Distributed] add FP8 support to NaN checker#135891kwen2501 wants to merge 2 commits intogh/kwen2501/59/basefrom
kwen2501 wants to merge 2 commits intogh/kwen2501/59/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135891
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27e3426 with merge base 0216936 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
PR Reviewer Guide 🔍
|
wconstab
approved these changes
Sep 12, 2024
Contributor
wconstab
left a comment
There was a problem hiding this comment.
LGTM, except for missing optimized template for the f8 kernel. Can you determine if its worth adding before deciding to land this as is or optimize further?
Adding support for `torch.float8_e4m3fn` and `torch.float8_e5m2` cc XilunWu H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 14, 2024
We check 8 x FP8 simultaneously, at size of 8 bytes. Pull Request resolved: #135961 Approved by: https://github.com/yifuwang, https://github.com/Skylion007 ghstack dependencies: #135891
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 15, 2024
Add support for Float8_e5m2, following similar algorithm used for Float8_e4m3fn (i.e. overflow check). Made `HasNanFP8x8` a template so that it is extendable based on dtype. Pull Request resolved: #136115 Approved by: https://github.com/Skylion007 ghstack dependencies: #135891, #135961
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Adding support for `torch.float8_e4m3fn` and `torch.float8_e5m2` Pull Request resolved: pytorch#135891 Approved by: https://github.com/wconstab
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
We check 8 x FP8 simultaneously, at size of 8 bytes. Pull Request resolved: pytorch#135961 Approved by: https://github.com/yifuwang, https://github.com/Skylion007 ghstack dependencies: pytorch#135891
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Add support for Float8_e5m2, following similar algorithm used for Float8_e4m3fn (i.e. overflow check). Made `HasNanFP8x8` a template so that it is extendable based on dtype. Pull Request resolved: pytorch#136115 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#135891, pytorch#135961
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: a9fb66a Pull Request resolved: pytorch/pytorch#135891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adding support for
torch.float8_e4m3fnandtorch.float8_e5m2cc @XilunWu @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o