Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135717
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4bb6b36 with merge base 83c594e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D62512551 |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This doesn't actually have anything to do with composites, it has to do with ops that return the unbacked symbol as an inner size/stride |
torch/_subclasses/fake_tensor.py
Outdated
| go, | ||
| tuple(pytree.tree_flatten(fake_out)), | ||
| tuple(pytree.tree_flatten(real_out)), | ||
| ) |
There was a problem hiding this comment.
this probably will make perf worse
There was a problem hiding this comment.
Ah, just updated to use the old version by default. Hopefully that's better.
Summary: Fixes #135632 Adds real tensor propagation for decompositions, checking any symbols on their outputs Reviewed By: ezyang Differential Revision: D62512551 Pulled By: pianpwk
e52041c to
4bb6b36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62512551 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#135632 Adds real tensor propagation for decompositions, checking any symbols on their outputs Pull Request resolved: pytorch#135717 Approved by: https://github.com/ezyang
Fixes #135632
Adds real tensor propagation for decompositions, checking any symbols on their outputs