Skip to content

Bump triton xpu pin and release version#135638

Closed
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
chuanqi129:triton_xpu_update_for_2.5
Closed

Bump triton xpu pin and release version#135638
chuanqi129 wants to merge 1 commit intopytorch:mainfrom
chuanqi129:triton_xpu_update_for_2.5

Conversation

@chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented Sep 10, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135638

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5744db7 with merge base 5c38aa7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 10, 2024
@chuanqi129 chuanqi129 requested a review from atalman September 10, 2024 23:58
@chuanqi129 chuanqi129 added ciflow/xpu Run XPU CI tasks module: xpu Intel XPU related issues labels Sep 10, 2024
@chuanqi129 chuanqi129 mentioned this pull request Sep 10, 2024
Merged
atalman
atalman approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Sep 11, 2024

@pytorchmergebot merge -f "lint and triton builds are passing"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 11, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman pushed a commit to atalman/pytorch that referenced this pull request Sep 11, 2024
@chuanqi129 @atalman
Bump triton xpu pin and release version (pytorch#135638)
89143b2 
Similar with pytorch#135627

Pull Request resolved: pytorch#135638
Approved by: https://github.com/atalman
This was referenced Sep 11, 2024
Closed
Merged
atalman pushed a commit to atalman/pytorch that referenced this pull request Sep 11, 2024
@chuanqi129 @atalman
Bump triton xpu pin and release version (pytorch#135638)
7346619 
Similar with pytorch#135627

Pull Request resolved: pytorch#135638
Approved by: https://github.com/atalman
atalman added a commit that referenced this pull request Sep 11, 2024
@atalman @chuanqi129
[Cherry-Pick] Bump triton pin and release version, revert temporary c…
cea5620 
…hanges to build from pin (#135613)

* Revert "[RELEASE-ONLY CHANGES] Temp changes to build triton from pin for first RC (#135517)"

This reverts commit 4a3dabd.

* Build triton from release branch

* triton_pin

* fix

* Bump triton xpu pin and release version (#135638)

Similar with #135627

Pull Request resolved: #135638
Approved by: https://github.com/atalman

---------

Co-authored-by: chuanqiw <chuanqi.wang@intel.com>
@kit1980
Copy link
Contributor

kit1980 commented Sep 17, 2024

@chuanqi129 All triton XPU builds failed on 2.5.0 release candidate with this PR.
See https://github.com/pytorch/pytorch/actions/runs/10894886278/job/30232276026
Any ideas?

@chuanqi129
Copy link
Collaborator Author

chuanqi129 commented Sep 17, 2024 •
edited
Loading

@chuanqi129 All triton XPU builds failed on 2.5.0 release candidate with this PR. See https://github.com/pytorch/pytorch/actions/runs/10894886278/job/30232276026 Any ideas?

Hi @kit1980, thanks to point out it. It caused by the xpu triton repo didn't create release/3.1.x branch, it used release/2.5.0 branch.

@vlad-penkin @pbchekin could you please create a new triton branch named release/3.1.x based on current release/2.5.0 branch. The build triton scripts has some hardcode for release binary build, refer https://github.com/pytorch/pytorch/blob/main/.github/scripts/build_triton_wheel.py#L106C47-L106C58. Thanks.

@chuanqi129
Copy link
Collaborator Author

chuanqi129 commented Sep 18, 2024

Hi @kit1980, the branch https://github.com/intel/intel-xpu-backend-for-triton/tree/release/3.1.x has been created, could you please help to try it again?

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@chuanqi129 @Chao1Han
Bump triton xpu pin and release version (pytorch#135638)
4f07269 
Similar with pytorch#135627

Pull Request resolved: pytorch#135638
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang EikanWang is a code owner

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chuanqi129 @atalman @pytorchmergebot @kit1980 @pytorchbot