[ONNX] Fix scaled_dot_product_attention with float scale#135594
Closed
titaiwangms wants to merge 1 commit intopytorch:mainfrom
Closed
[ONNX] Fix scaled_dot_product_attention with float scale#135594titaiwangms wants to merge 1 commit intopytorch:mainfrom
titaiwangms wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135594
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f982235 with merge base dfb2b66 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
approved these changes
Sep 10, 2024
justinchuby
reviewed
Sep 10, 2024
| ), "is_causal and attn_mask cannot be set at the same time" | ||
| assert not enable_gqa, "conversion of scaled_dot_product_attention not implemented if enable_gqa is True" | ||
|
|
||
| scale = symbolic_helper._maybe_get_const(scale, "f") |
Collaborator
There was a problem hiding this comment.
Just making sure: does it work for fp16?
Contributor
There was a problem hiding this comment.
The fix seem to work with my FP16 case, I see no warnings either.
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
@titaiwangms did you want to cherry pick this as well? I can go under category (2) or (3) I think. |
Collaborator
Author
Sure! Looks like people need this. |
titaiwangms
added a commit
to titaiwangms/pytorch
that referenced
this pull request
Sep 11, 2024
) Fixes pytorch#125158 Pull Request resolved: pytorch#135594 Approved by: https://github.com/justinchuby (cherry picked from commit e48ee2c)
malfet
pushed a commit
that referenced
this pull request
Sep 12, 2024
Fixes #125158 Pull Request resolved: #135594 Approved by: https://github.com/justinchuby (cherry picked from commit e48ee2c)
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
) Fixes pytorch#125158 Pull Request resolved: pytorch#135594 Approved by: https://github.com/justinchuby
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125158