Download pre-compiled AOTriton from GitHub unless AOTRITON_INSTALL_FROM_SOURCE=1 is set#135560
Closed
xinyazhang wants to merge 12 commits intopytorch:mainfrom
Closed
Download pre-compiled AOTriton from GitHub unless AOTRITON_INSTALL_FROM_SOURCE=1 is set#135560xinyazhang wants to merge 12 commits intopytorch:mainfrom
xinyazhang wants to merge 12 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135560
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 14 Unrelated FailuresAs of commit cbea4f3 with merge base eb0fe02 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@jithunnair-amd @pruthvistony PR filed per request in #134498 (comment) |
Collaborator
Author
|
@pytorchbot tag "ciflow/rocm" "module:rocm" |
|
❌ 🤖 pytorchbot command failed: Try |
Collaborator
Author
|
@pytorchbot label "ciflow/rocm" "module:rocm" |
|
Can't add following labels to PR: ciflow/rocm. Please ping one of the reviewers for help. |
cab94b4 to
311192f
Compare
Otherwise bdist_wheel will miss libaotriton_v2.so
This also updates aotriton_version.txt's format
f8951df to
1efc9a4
Compare
Some additional changes on top of pytorch@a8f2cb6 (pytorch#135560) to: 1. Remove condition for preinstalled aotriton: always install/build aotriton as part of PyTorch build 2. Remove all aotriton preinstall steps from CI and manywheel dockerfiles 3. Specify list of manylinux values for each ROCm version in aotriton_version.txt: to allow for differing manylinux values as we transition from manylinux2_17 to manylinux2_28
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using pre-compiled tarball is the recommended way to use AOTriton at the moment.
Requires updates once #134498 is merged.