[Profiler] Torch Profiler distributed info is not JSON serializable#135548

Closed

sraikund16 wants to merge 1 commit intopytorch:mainfrom

sraikund16:export-D62411619

Contributor

sraikund16 commented Sep 9, 2024

Summary: To fix #133308 we must create an encoder for numpy values so we can serialize the distributed metadata to JSON.

Test Plan: Added unit test to check that numpy values can be serialized

Differential Revision: D62411619

sraikund16 requested a review from aaronenyeshi as a code owner

September 9, 2024 23:31

pytorch-bot bot commented Sep 9, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135548

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 2659c11 with merge base cd472bb ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (disabled by #134602)
test_transformers.py::TestSDPAPrivateUse1Only::test_scaled_dot_product_fused_attention_overrideable_backward
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge) (gh) (disabled by #134602)
test_transformers.py::TestSDPAPrivateUse1Only::test_scaled_dot_product_fused_attention_overrideable_backward

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Lint / lintrunner-noclang / linux-job (gh) (trunk failure)
>>> Lint for test/distributed/_composable/test_composability/test_2d_composability.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Sep 9, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

facebook-github-bot added the fb-exported label

sraikund16 added the topic: bug fixes label

aaronenyeshi approved these changes

View reviewed changes

Member

aaronenyeshi left a comment

LGTM, pleas check CI signals!

pytorch-bot bot added the ciflow/trunk label

sraikund16 added the release notes: profiler label

sraikund16 force-pushed the export-D62411619 branch from 3754f40 to c3b7f3e Compare

September 11, 2024 19:02

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from c3b7f3e to f1f140e Compare

September 11, 2024 19:08

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from f1f140e to 669ce01 Compare

September 11, 2024 20:50

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 669ce01 to 5b929f1 Compare

September 11, 2024 20:55

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

1 similar comment

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 5b929f1 to 378c279 Compare

September 11, 2024 22:19

Contributor

facebook-github-bot commented Sep 11, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch 2 times, most recently from 2e73094 to f13deca Compare

September 12, 2024 00:07

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

1 similar comment

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from e2823ad to dec7480 Compare

September 12, 2024 17:45

sraikund16 force-pushed the export-D62411619 branch from dec7480 to da4cd1d Compare

September 12, 2024 17:51

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from da4cd1d to 9c263bf Compare

September 12, 2024 18:05

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 9c263bf to 43d7b34 Compare

September 12, 2024 18:43

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

1 similar comment

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 added a commit to sraikund16/pytorch that referenced this pull request


          [Profiler] Torch Profiler distributed info is not JSON serializable (p…

3a7195b

…ytorch#135548)

Summary:
Pull Request resolved: pytorch#135548

To fix pytorch#133308 we must create an encoder for numpy values so we can serialize the distributed metadata to JSON.

Test Plan: Added unit test to check that numpy values can be serialized

Reviewed By: aaronenyeshi

Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 43d7b34 to 3a7195b Compare

September 12, 2024 18:51

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 3a7195b to 4da02d5 Compare

September 12, 2024 19:58


          [Profiler] Torch Profiler distributed info is not JSON serializable (p…

2659c11

…ytorch#135548)

Summary:
Pull Request resolved: pytorch#135548

To fix pytorch#133308 we must create an encoder for numpy values so we can serialize the distributed metadata to JSON.

Test Plan: Added unit test to check that numpy values can be serialized

Reviewed By: aaronenyeshi

Differential Revision: D62411619

sraikund16 force-pushed the export-D62411619 branch from 4da02d5 to 2659c11 Compare

September 12, 2024 20:05

Contributor

facebook-github-bot commented Sep 12, 2024

This pull request was exported from Phabricator. Differential Revision: D62411619

Contributor

facebook-github-bot commented Sep 13, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 13, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

062681a

pytorchmergebot removed the merging label

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request


          [Profiler] Torch Profiler distributed info is not JSON serializable (p…

13f56c1

…ytorch#135548)

Summary: To fix pytorch#133308 we must create an encoder for numpy values so we can serialize the distributed metadata to JSON.

Test Plan: Added unit test to check that numpy values can be serialized

Differential Revision: D62411619

Pull Request resolved: pytorch#135548
Approved by: https://github.com/aaronenyeshi, https://github.com/albanD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged topic: bug fixes topic: not user facing