Skip to content

Use upload-artifact@v4.4.0 for create_release.yml#135528

Closed
atalman wants to merge 1 commit intopytorch:mainfrom
atalman:fix_followup_upload_download
Closed

Use upload-artifact@v4.4.0 for create_release.yml#135528
atalman wants to merge 1 commit intopytorch:mainfrom
atalman:fix_followup_upload_download

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Sep 9, 2024

Fixes failure: https://github.com/pytorch/pytorch/actions/runs/10780281005/job/29895846007

Due broken sync

actions/upload-artifact@v2
and
actions/download-artifact@v4.1.7

@atalman atalman requested a review from a team as a code owner September 9, 2024 20:16
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135528

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 3ff6db0 with merge base 09a5e88 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 9, 2024
@malfet
Copy link
Contributor

malfet commented Sep 9, 2024

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Sep 9, 2024

@pytorchbot cherry-pick --onto release/2.5 -c critical

pytorchbot pushed a commit that referenced this pull request Sep 9, 2024
Fixes failure: https://github.com/pytorch/pytorch/actions/runs/10780281005/job/29895846007

Due broken sync
```
actions/upload-artifact@v2
and
actions/download-artifact@v4.1.7
```

Pull Request resolved: #135528
Approved by: https://github.com/kit1980, https://github.com/malfet

(cherry picked from commit 9b76449)
@pytorchbot
Copy link
Collaborator

Cherry picking #135528

The cherry pick PR is at #135534 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

atalman added a commit that referenced this pull request Sep 10, 2024
Use upload-artifact@v4.4.0 for create_release.yml (#135528)

Fixes failure: https://github.com/pytorch/pytorch/actions/runs/10780281005/job/29895846007

Due broken sync
```
actions/upload-artifact@v2
and
actions/download-artifact@v4.1.7
```

Pull Request resolved: #135528
Approved by: https://github.com/kit1980, https://github.com/malfet

(cherry picked from commit 9b76449)

Co-authored-by: atalman <atalman@fb.com>
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Fixes failure: https://github.com/pytorch/pytorch/actions/runs/10780281005/job/29895846007

Due broken sync
```
actions/upload-artifact@v2
and
actions/download-artifact@v4.1.7
```

Pull Request resolved: pytorch#135528
Approved by: https://github.com/kit1980, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants