Tests Generelization for multiple accelerator devices#135242
Closed
rahulsingh-intel wants to merge 50 commits intopytorch:mainfrom
Closed
Tests Generelization for multiple accelerator devices#135242rahulsingh-intel wants to merge 50 commits intopytorch:mainfrom
rahulsingh-intel wants to merge 50 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135242
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4aec93c with merge base 228963a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
zeshengzong
reviewed
Sep 6, 2024
Contributor
There was a problem hiding this comment.
Hello, this might optimized to pythonic expression, like to_device = self.rank if TEST_CUDA else device I think. :D
And I saw there's some repeating in this logic, extract a method might be an option to reduce duplication, and convenient for other device if they want to reuse test-cases as well. Thanks
|
/easycla |
|
@rahulsingh-intel : can you please address this change pointed out by @awgu to the PR after rebase to main. #133209 (comment). Thanks |
4712e89 to
df5bbc0
Compare
ec978d3 to
4aec93c
Compare
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Motivation: Generalize unit tests so that can be executed for cuda and non cuda devices. Depedency : #133209 Merged now. There was a #135242 for these changes and closed due to in correct commits. I have incoroprated the changes as suggested in comments. @kwen2501 @zeshengzong Please review the changes. Pull Request resolved: #139184 Approved by: https://github.com/kwen2501 Co-authored-by: Yu, Guangye <guangye.yu@intel.com>
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Motivation: Generalize unit tests so that can be executed for cuda and non cuda devices. Depedency : #133209 Merged now. There was a #135242 for these changes and closed due to in correct commits. I have incoroprated the changes as suggested in comments. @kwen2501 @zeshengzong Please review the changes. Pull Request resolved: #139184 Approved by: https://github.com/kwen2501 Co-authored-by: Yu, Guangye <guangye.yu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Generalize unit tests so that can be executed for cuda and non cuda devices.
Brief: Changes have depedency on #133209.
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @gujinghui @PenghuiCheng @jianyuh @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal @EikanWang @voznesenskym @penguinwu @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @rec @xmfan @XilunWu