Skip to content

Fix dynamo benchmark skip logic for cpu device#135193

Closed
zxd1997066 wants to merge 4 commits intopytorch:mainfrom
zxd1997066:xiangdong/fix_hf
Closed

Fix dynamo benchmark skip logic for cpu device#135193
zxd1997066 wants to merge 4 commits intopytorch:mainfrom
zxd1997066:xiangdong/fix_hf

Conversation

@zxd1997066
Copy link
Contributor

@zxd1997066 zxd1997066 commented Sep 5, 2024 •
edited
Loading

Fixes #132380, adjust torchbench and huggingface skip models list, then we can remove --no-skip when running benchmarks on 3 suites.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135193

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d65e3ca with merge base 3bebc09 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zxd1997066 zxd1997066 force-pushed the xiangdong/fix_hf branch 3 times, most recently from 27135cf to dafa8f5 Compare September 6, 2024 06:02
@zxd1997066 zxd1997066 marked this pull request as ready for review September 6, 2024 06:04
@zxd1997066
Copy link
Contributor Author

zxd1997066 commented Sep 6, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 6, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 6, 2024

Successfully rebased xiangdong/fix_hf onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xiangdong/fix_hf && git pull --rebase)

@zxd1997066 zxd1997066 force-pushed the xiangdong/fix_hf branch 5 times, most recently from fa2ab4b to f5895a9 Compare September 6, 2024 14:00
@chuanqi129
Copy link
Collaborator

chuanqi129 commented Sep 6, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 6, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 6, 2024

Successfully rebased xiangdong/fix_hf onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xiangdong/fix_hf && git pull --rebase)

@chuanqi129
Copy link
Collaborator

chuanqi129 commented Sep 6, 2024

Suggest to rename the title to "Fix dynamo benchmark skip logic for cpu device"

@zxd1997066 zxd1997066 changed the title Fix benchmarks/dynamo/huggingface configuration typo and align skipped cpu models as previous Fix dynamo benchmark skip logic for cpu device Sep 8, 2024
@chuanqi129
Copy link
Collaborator

chuanqi129 commented Sep 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 8, 2024

Successfully rebased xiangdong/fix_hf onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xiangdong/fix_hf && git pull --rebase)

@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 9, 2024
@chuanqi129 chuanqi129 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2024
@chunyuan-w chunyuan-w added the topic: not user facing topic category label Sep 9, 2024
@chunyuan-w
Copy link
Collaborator

chunyuan-w commented Sep 9, 2024

Hi @jansel @desertfire could you please help review this PR?

@chuanqi129
Copy link
Collaborator

chuanqi129 commented Sep 10, 2024

@pytorchbot merge

1 similar comment
@zxd1997066
Copy link
Contributor Author

zxd1997066 commented Sep 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 10, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zxd1997066 added a commit to zxd1997066/pytorch that referenced this pull request Sep 10, 2024
@zxd1997066
Fix dynamo benchmark skip logic for cpu device (pytorch#135193)
c1c091e 
Fixes pytorch#132380, adjust torchbench and huggingface skip models list, then we can remove `--no-skip` when running benchmarks on 3 suites.

Pull Request resolved: pytorch#135193
Approved by: https://github.com/chuanqi129, https://github.com/jansel

(cherry picked from commit 7ec17b4)
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Sep 11, 2024
@zxd1997066 @facebook-github-bot
Fix dynamo benchmark skip logic for cpu device (#135193)
8351474 
Summary:
Fixes #132380, adjust torchbench and huggingface skip models list, then we can remove `--no-skip` when running benchmarks on 3 suites.

X-link: pytorch/pytorch#135193
Approved by: https://github.com/chuanqi129, https://github.com/jansel

Reviewed By: izaitsevfb

Differential Revision: D62465671

fbshipit-source-id: 4b7e38c50bd3f09b9422f14ccc8cd01a56892bb5
@zxd1997066 zxd1997066 mentioned this pull request Sep 13, 2024
Closed
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@zxd1997066 @Chao1Han
Fix dynamo benchmark skip logic for cpu device (pytorch#135193)
faf76de 
Fixes pytorch#132380, adjust torchbench and huggingface skip models list, then we can remove `--no-skip` when running benchmarks on 3 suites.

Pull Request resolved: pytorch#135193
Approved by: https://github.com/chuanqi129, https://github.com/jansel
kit1980 pushed a commit that referenced this pull request Sep 20, 2024
@zxd1997066
Fix dynamo benchmark skip logic for cpu device (#135193) (#135793)
ffed7b7 
Fixes #132380, adjust torchbench and huggingface skip models list, then we can remove `--no-skip` when running benchmarks on 3 suites.

Pull Request resolved: #135193
Approved by: https://github.com/chuanqi129, https://github.com/jansel

(cherry picked from commit 7ec17b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@chuanqi129 chuanqi129 chuanqi129 approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@jgong5 jgong5 Awaiting requested review from jgong5

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[inductor][cpu] LayoutLMForSequenceClassification amp single thread accuracy failure

7 participants

@zxd1997066 @pytorchmergebot @chuanqi129 @chunyuan-w @jansel @ezyang @pytorchbot