[Inductor] Use argument names as the key for the constants dict and the signature dict#135170
[Inductor] Use argument names as the key for the constants dict and the signature dict#135170Jokeren wants to merge 4 commits intopytorch:mainfrom
constants dict and the signature dict#135170Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135170
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3f641db with merge base 62b221d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@shunting314 maybe? Or could you help me find someone to review the PR? |
|
@pytorchbot label "module: inductor" |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ionaries (#135406) Previous PR forgets to change two other places that also create `constants` and `signature`. #135170 Pull Request resolved: #135406 Approved by: https://github.com/jansel
… the `signature` dict (pytorch#135170) Referencing how triton constructs these dictionaries https://github.com/triton-lang/triton/blob/ca3fb5f6fa6365445d2d982d137aa5cb2a80f547/python/triton/runtime/jit.py#L639 Pull Request resolved: pytorch#135170 Approved by: https://github.com/htyu
…ionaries (pytorch#135406) Previous PR forgets to change two other places that also create `constants` and `signature`. pytorch#135170 Pull Request resolved: pytorch#135406 Approved by: https://github.com/jansel
Referencing how triton constructs these dictionaries
https://github.com/triton-lang/triton/blob/ca3fb5f6fa6365445d2d982d137aa5cb2a80f547/python/triton/runtime/jit.py#L639
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang