Skip to content

Add support for dict batches in DataLoader#1350

Closed
chsasank wants to merge 1 commit intopytorch:masterfrom
qureai:dataloader
Closed

Add support for dict batches in DataLoader#1350
chsasank wants to merge 1 commit intopytorch:masterfrom
qureai:dataloader

Conversation

@chsasank
Copy link
Contributor

  1. There was a bug in DataLoader code. Lists, tuples, dicts, sets are instances of collections.Iterable. Only list and tuples are instances of collections.Sequence and only dicts are instances of collections.Mapping.
  2. Add support for dict like batches. Implementation is fairly straightforward.

Sasank.

@apaszke
Copy link
Contributor

apaszke commented Apr 25, 2017

I think it's a duplicate of #1131, that also added tests (that failed right now, because sets are unordered, but the tests don't handle that).

@chsasank
Copy link
Contributor Author

chsasank commented Apr 25, 2017

Indeed, even the PR titles are almost the same! Sorry for creating a duplicate.

Given that PR #1131 has not been worked on for 23 days, is there something I can do to have it merged? I can fork source branch of #1131 and create a new PR.

Thanks,
Sasank.

@apaszke
Copy link
Contributor

apaszke commented Apr 25, 2017

I think the only missing thing is fixing that test.

@chsasank
Copy link
Contributor Author

Cool, I'll fix it and create another PR.

@chsasank chsasank closed this Apr 25, 2017
@chsasank chsasank deleted the dataloader branch April 25, 2017 08:59
eqy pushed a commit to eqy/pytorch that referenced this pull request Jan 20, 2022
* Refactor War Sync Insertion Pass (pytorch#1339)
* Remove kir::Expr::scope_ (pytorch#1341)
* Fusion IR Refactor (pytorch#1343)
* Refactor KIR Step 1 - Remove kir::Node (pytorch#1347)
* Refactor KIR Step 2 - TMP IrUtils change (pytorch#1348)
* Refactor KIR Step 3 - Remove kir::Expr and kir::Val. (pytorch#1349)
* Refactor KIR Step 4 - Remove kir::Bool,Double,Int,NamedScalar. (pytorch#1350)
* Refactor KIR Step 5 - Remove kir::IterDomain/TensorDomain/TensorView (pytorch#1351)
* Refactor KIR Step 6 - Remove 
 kir::UnaryOp/BinaryOp/TernaryOp/ReductionOp/WelfordOp/BroadcastOp. (pytorch#1352)
* Refactor KIR Step 7 - Remove kir dispatch (pytorch#1353)
* Refactor KIR Step 8 - Clean up lower_utils (pytorch#1355)
* Refactor KIR Step 9 - lower_utils ir_utils::applyReplacements. (pytorch#1354)
* Refactor KIR Step 10 - Remove kir_printer in favor of io_stream (pytorch#1356)
pytorch-bot bot pushed a commit that referenced this pull request Mar 12, 2024
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pytorch-bot bot pushed a commit that referenced this pull request Mar 19, 2024
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pytorch-bot bot pushed a commit that referenced this pull request Apr 10, 2024
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pytorch-bot bot pushed a commit that referenced this pull request Apr 30, 2024
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
petrex pushed a commit to petrex/pytorch that referenced this pull request Sep 23, 2024
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jagadish-amd pushed a commit to jagadish-amd/pytorch that referenced this pull request Jan 29, 2025
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants