compiled autograd: support accumulate_grad_ in DTensor sharding#133580
Closed
bdhirsh wants to merge 1 commit intogh/bdhirsh/606/basefrom
Closed
compiled autograd: support accumulate_grad_ in DTensor sharding#133580bdhirsh wants to merge 1 commit intogh/bdhirsh/606/basefrom
bdhirsh wants to merge 1 commit intogh/bdhirsh/606/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133580
Note: Links to docs will display an error until the docs builds have been completed. ❌ 13 New Failures, 2 Unrelated FailuresAs of commit d319c96 with merge base 454713f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
ghstack-source-id: ab85b2e Pull Request resolved: pytorch/pytorch#133580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can add a unit test if someone wants, although I'm planning to have this stack culminate in the DTensor + compiled autograd from this issue passing: #127797
accumulate_gradshould (I think?) have a trivially-pointwise sharding rule. We also need to tweak DTensor to handle ops with no returns.Stack from ghstack (oldest at bottom):
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o