Skip to content

CircleCI: enable all flaky tests#13356

Closed
yf225 wants to merge 3 commits intopytorch:masterfrom
yf225:circleci_enable_flaky_tests
Closed

CircleCI: enable all flaky tests#13356
yf225 wants to merge 3 commits intopytorch:masterfrom
yf225:circleci_enable_flaky_tests

Conversation

@yf225
Copy link
Copy Markdown
Contributor

@yf225 yf225 commented Oct 30, 2018

A few Caffe2 tests are currently disabled in py2-gcc4.8-ubuntu14.04 test job because they are known to be flaky. #13055 likely had fixed the flakiness, and this PR tests it.

Fixes #12395.

@yf225 yf225 requested review from anderspapitto and ezyang October 30, 2018 23:36
@yf225 yf225 changed the title [WIP] CircleCI: enable all flaky tests CircleCI: enable all flaky tests Oct 31, 2018
Copy link
Copy Markdown
Contributor

@anderspapitto anderspapitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they're passing now, ship it

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
A few Caffe2 tests are currently disabled in `py2-gcc4.8-ubuntu14.04` test job because they are known to be flaky. pytorch#13055 likely had fixed the flakiness, and this PR tests it.

Fixes pytorch#12395.
Pull Request resolved: pytorch#13356

Differential Revision: D12858206

Pulled By: yf225

fbshipit-source-id: 491c9c4a5c48ac1b791fdc9d78acf66091e80457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Caffe2 flaky tests on CircleCI

4 participants