Skip to content

[Reland] Add wrappers for synchronous GPUDirect Storage APIs#133489

Closed
mikaylagawarecki wants to merge 1 commit intopytorch:mainfrom
mikaylagawarecki:gds-new-3
Closed

[Reland] Add wrappers for synchronous GPUDirect Storage APIs#133489
mikaylagawarecki wants to merge 1 commit intopytorch:mainfrom
mikaylagawarecki:gds-new-3

Conversation

@mikaylagawarecki
Copy link
Copy Markdown
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 14, 2024 •
edited
Loading

Reland #130633

Based in part on NVIDIA/apex#1774
USE_CUFILE turned off by default in this version

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133489

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7b7abe3 with merge base c2eeda5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 14, 2024

@mikaylagawarecki has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

albanD
albanD approved these changes Aug 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 15, 2024 16:19
@mikaylagawarecki mikaylagawarecki added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 15, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Aug 15, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 15, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki mikaylagawarecki mentioned this pull request Aug 16, 2024
Open
@jakirkham jakirkham mentioned this pull request Aug 30, 2024
Closed
kit1980 added a commit that referenced this pull request Oct 18, 2024
@kit1980
[RELEASE-ONLY CHANGE] Don't try to load cufile
1f48ccd 
cufile is not available in AlmaLinux/AmazonLinux default configuration.
cufile is not actually used currently by default - #133489
@kit1980 kit1980 mentioned this pull request Oct 18, 2024
Closed
kit1980 added a commit that referenced this pull request Oct 21, 2024
@kit1980
Don't try to load cufile
075efb5 
Trying to loading it caused a big issue with 2.5.0 release - #138324
cufile is not actually used currently by default - #133489
@kit1980 kit1980 mentioned this pull request Oct 21, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 22, 2024
@kit1980 @pytorchmergebot
Don't try to load cufile (#138501)
012ff2a 
Trying to loading it caused a big issue with 2.5.0 release - #138324

cufile is not actually used currently by default, see #133489

Pull Request resolved: #138501
Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet
pytorchbot pushed a commit that referenced this pull request Oct 22, 2024
@kit1980 @pytorchbot
Don't try to load cufile (#138501)
3e14323 
Trying to loading it caused a big issue with 2.5.0 release - #138324

cufile is not actually used currently by default, see #133489

Pull Request resolved: #138501
Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet

(cherry picked from commit 012ff2a)
@pytorchbot pytorchbot mentioned this pull request Oct 22, 2024
Merged
kit1980 added a commit that referenced this pull request Oct 22, 2024
@pytorchbot @kit1980
Don't try to load cufile (#138539)
cde6b38 
Don't try to load cufile (#138501)

Trying to loading it caused a big issue with 2.5.0 release - #138324

cufile is not actually used currently by default, see #133489

Pull Request resolved: #138501
Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet

(cherry picked from commit 012ff2a)

Co-authored-by: Sergii Dymchenko <sdym@meta.com>
SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@kit1980 @SamGinzburg
Don't try to load cufile (#138501)
8f3f904 
Trying to loading it caused a big issue with 2.5.0 release - #138324

cufile is not actually used currently by default, see #133489

Pull Request resolved: #138501
Approved by: https://github.com/atalman, https://github.com/mikaylagawarecki, https://github.com/malfet
@functionstackx functionstackx mentioned this pull request Feb 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikaylagawarecki @facebook-github-bot @pytorchmergebot @albanD