Skip to content

Exclude test_transformers and unit tests which require recent GPU arch#132895

Closed
BLOrange-AMD wants to merge 15 commits intopytorch:mainfrom
ROCm:0807_test_results_info
Closed

Exclude test_transformers and unit tests which require recent GPU arch#132895
BLOrange-AMD wants to merge 15 commits intopytorch:mainfrom
ROCm:0807_test_results_info

Conversation

@BLOrange-AMD
Copy link
Contributor

@BLOrange-AMD BLOrange-AMD commented Aug 7, 2024 •
edited by pytorch-bot bot
Loading

This PR is to exclude test_transformers on ROCm temporarily and skip some unit tests which require recent GPU arch.

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

@BLOrange-AMD BLOrange-AMD requested a review from a team as a code owner August 7, 2024 16:56
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132895

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 8bf29b2 with merge base adcce53 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 7, 2024
@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 7, 2024

@pytorchbot label ciflow/rocm

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2024

Can't add following labels to PR: ciflow/rocm. Please ping one of the reviewers for help.

@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 7, 2024 •
edited
Loading

@pytorchbot label keep-going

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 7, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'keep-going' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@jithunnair-amd jithunnair-amd added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm keep-going Don't stop on first failure, keep running tests until the end labels Aug 7, 2024
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 8, 2024
@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2024

Successfully rebased 0807_test_results_info onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 0807_test_results_info && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the 0807_test_results_info branch from 070cf7a to e9c5252 Compare August 8, 2024 01:37
@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2024

Successfully rebased 0807_test_results_info onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 0807_test_results_info && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the 0807_test_results_info branch from e9c5252 to dd2d16d Compare August 8, 2024 16:49
@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 12, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 12, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 12, 2024

Successfully rebased 0807_test_results_info onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 0807_test_results_info && git pull --rebase)

@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 13, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2024

Successfully rebased 0807_test_results_info onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 0807_test_results_info && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 26, 2024

Successfully rebased 0807_test_results_info onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 0807_test_results_info && git pull --rebase)

@pruthvistony
Copy link
Collaborator

pruthvistony commented Aug 26, 2024 •
edited
Loading

@BLOrange-AMD ,
Please fix the lint error.
Once the CI is green, please move the PR out of draft.

@pruthvistony pruthvistony added the rocm priority high priority ROCm PRs from performance or other aspects label Aug 26, 2024
@pruthvistony pruthvistony mentioned this pull request Aug 26, 2024
Closed
@pruthvistony pruthvistony marked this pull request as ready for review August 27, 2024 04:33
@pruthvistony pruthvistony requested review from atalman and malfet August 27, 2024 04:33
@pruthvistony
Copy link
Collaborator

pruthvistony commented Aug 27, 2024

@malfet @atalman ,
Please help in review of this PR.

@BLOrange-AMD
Copy link
Contributor Author

BLOrange-AMD commented Aug 27, 2024 •
edited
Loading

Hi @malfet @atalman, could you help to review this PR? This will help us to bring ROCm CI back to green. Thanks.

@malfet
Copy link
Contributor

malfet commented Aug 27, 2024

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 27, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pragupta pragupta mentioned this pull request Aug 29, 2024
Closed
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@BLOrange-AMD @Chao1Han
Exclude test_transformers and unit tests which require recent GPU arch (
a3f8bf2 
pytorch#132895)

This PR is to exclude test_transformers on ROCm temporarily and skip some unit tests which require recent GPU arch.

Pull Request resolved: pytorch#132895
Approved by: https://github.com/jithunnair-amd, https://github.com/pruthvistony, https://github.com/malfet
jataylo pushed a commit to ROCm/pytorch that referenced this pull request Oct 21, 2024
@BLOrange-AMD @jataylo
Exclude test_transformers and unit tests which require recent GPU arch (
01d2ff9 
pytorch#132895)

This PR is to exclude test_transformers on ROCm temporarily and skip some unit tests which require recent GPU arch.

Pull Request resolved: pytorch#132895
Approved by: https://github.com/jithunnair-amd, https://github.com/pruthvistony, https://github.com/malfet

(cherry picked from commit 16b8146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jithunnair-amd jithunnair-amd jithunnair-amd approved these changes

@malfet malfet malfet approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm Trigger "default" config CI on ROCm keep-going Don't stop on first failure, keep running tests until the end Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source rocm priority high priority ROCm PRs from performance or other aspects rocm This tag is for PRs from ROCm team topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BLOrange-AMD @pytorchmergebot @jithunnair-amd @pruthvistony @malfet @cpuhrsch @pytorchbot