[Docker] Replace epel release rpm by yum install by atalman · Pull Request #132449 · pytorch/pytorch

atalman · 2024-08-01T21:53:49Z

URL: https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm is not available anymore, hence replacing this with yum epel-release install.

As a backup plan this is available still : https://archives.fedoraproject.org/pub/archive/epel/7/x86_64/Packages/e/epel-release-7-14.noarch.rpm

Saved on our s3 path, just in case: https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm

Please note, We are still using for installs like this:

RUN yum install -y \
    https://repo.ius.io/ius-release-el7.rpm \
	https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm

Test in CI

pytorch-bot · 2024-08-01T21:53:52Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132449

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 8 Unrelated Failures

As of commit 6721e08 with merge base 92bebb4 ():

NEW FAILURE - The following job has failed:

pull / linux-focal-rocm6.1-py3.8 / build (gh)
Process completed with exit code 1.

CANCELLED JOBS - The following jobs were cancelled. Please retry:

docker-builds / docker-build (linux.12xlarge, pytorch-linux-focal-cuda11.8-cudnn9-py3-gcc9) (gh)
##[error]The operation was canceled.
docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-xpu-2024.0-py3) (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
test_python_dispatch.py::TestPythonDispatch::test_torch_dispatch_mode_subclass_priority
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
functorch/test_aotdispatch.py::TestAOTAutograd::test_input_data_and_metadata_mutation_aliases_other_input
pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
test_python_dispatch.py::TestPythonDispatch::test_torch_dispatch_mode_subclass_priority
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
functorch/test_aotdispatch.py::TestAOTAutograd::test_input_data_and_metadata_mutation_aliases_other_input
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
test_python_dispatch.py::TestPythonDispatch::test_torch_dispatch_mode_subclass_priority
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
functorch/test_aotdispatch.py::TestAOTAutograd::test_input_data_and_metadata_mutation_aliases_other_input
pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
test_python_dispatch.py::TestPythonDispatch::test_torch_dispatch_mode_subclass_priority
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh) (trunk failure)
functorch/test_aotdispatch.py::TestAOTAutograd::test_input_data_and_metadata_mutation_aliases_other_input

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fix fix test test test Revert "test" This reverts commit c2655877fdf23f74da543d25f659f9fd9c39c846.

malfet

LGTM, though we should move away from CentOS 7

atalman · 2024-08-02T00:13:47Z

@pytorchmergebot merge -f "lint and docker builds are green"

pytorchmergebot · 2024-08-02T00:15:56Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ytorch/pytorch#132449

* Update ROCm instructions for manylinux * Sync devtoolset version to 11 with CUDA manylinux_2_28 entry * Update Dockerfile for ROCm * Add almalinux case * Use | to OR different conditions and avoid repetition * Use devtoolset 11 in alignment with CUDA manylinux config * Magma build preinstalls (cherry picked from commit 9a803c9) * Add symlink to python (cherry picked from commit 5c4bf9f) * Add ROCM_PATH * Use cpu_final to get the devtoolset PATH/LD_LIBRARY_PATH settings and pip cmake install * Move creation of python link to install_rocm_magma.sh since it's only needed for Magma * Cmake updates * Add Almalinux case for bundling system libs * Set _GLIBCXX_USE_CXX11_ABI=1 for ROCm since RHEL8 ROCm packages refer to cxx11-abi symbols, so PyTorch build fails if _GLIBCXX_USE_CXX11_ABI=0 * Need * to have a match * Install numpy<2.0.0 for older release branches * Enable MIOpen build from source for ROCm6.1 to see if it resolves segfault issue Remove existing sqlite3.pc to make cget happy * Add conditions for ROCm6.2 and ROCm6.3 * Don't use set -e * Upgrade cmake version to enable CK to build for ROCm6.2 * Disable building from source for MIOpen and reinstate set -e * Add librocm-core.so (#50) (cherry picked from commit 2d3fb6f) * Remove all references to devtoolset * Update cmake version to 3.28.4 * Skip epel-7 rpm download * Skip epel-7 rpm download * Install epel-7 from PyTorch AWS backup repo (similar to upstream PR pytorch/pytorch#132449 * Use DEVTOOLSET_VERSION 9 for manylinux2_28 * Move AOTriton build step to PyTorch build script (since different aotriton for different pytorch releases) * Install libaotriton_v2.so before we look for it * Comments * Comments * Revert "Remove all references to devtoolset" This reverts commit 43d70a7. * Comments * Add gfx942 as default arch * Use correct GPU_IMAGE for manylinux_2_28 * Tab lint * Do not rebuild CK; Remove old ROCm cruft --------- Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>

URL: https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm is not available anymore, hence replacing this with yum epel-release install. As a backup plan this is available still : https://archives.fedoraproject.org/pub/archive/epel/7/x86_64/Packages/e/epel-release-7-14.noarch.rpm Saved on our s3 path, just in case: https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm Please note, We are still using for installs like this: ``` RUN yum install -y \ https://repo.ius.io/ius-release-el7.rpm \ https://ossci-linux.s3.amazonaws.com/epel-release-7-14.noarch.rpm ``` Test in CI Pull Request resolved: pytorch#132449 Approved by: https://github.com/kit1980, https://github.com/seemethere, https://github.com/malfet

[Docker] Replace epel release rpm by yum install

d62c0fe

atalman requested a review from jeffdaily as a code owner August 1, 2024 21:53

pytorch-bot bot added the topic: not user facing topic category label Aug 1, 2024

kit1980 approved these changes Aug 1, 2024

View reviewed changes

seemethere approved these changes Aug 1, 2024

View reviewed changes

[Docker] Replace epel release rpm by yum install

6721e08

fix fix test test test Revert "test" This reverts commit c2655877fdf23f74da543d25f659f9fd9c39c846.

atalman force-pushed the epel_release_fix branch from c265587 to 6721e08 Compare August 1, 2024 23:33

malfet approved these changes Aug 1, 2024

View reviewed changes

pytorchmergebot added the merging label Aug 2, 2024

pytorchmergebot closed this in 0016be8 Aug 2, 2024

pytorchmergebot added Merged and removed merging labels Aug 2, 2024

jithunnair-amd added a commit to jithunnair-amd/builder that referenced this pull request Aug 3, 2024

Install epel-7 from PyTorch AWS backup repo (similar to upstream PR p…

7aa92d0

…ytorch/pytorch#132449

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Docker] Replace epel release rpm by yum install#132449

[Docker] Replace epel release rpm by yum install#132449
atalman wants to merge 2 commits intopytorch:mainfrom
atalman:epel_release_fix

atalman commented Aug 1, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Aug 1, 2024 •

edited

Loading

Uh oh!

malfet left a comment

Uh oh!

atalman commented Aug 2, 2024

Uh oh!

pytorchmergebot commented Aug 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

atalman commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132449

❌ 1 New Failure, 2 Cancelled Jobs, 8 Unrelated Failures

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

atalman commented Aug 2, 2024

Uh oh!

pytorchmergebot commented Aug 2, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

atalman commented Aug 1, 2024 •

edited

Loading

pytorch-bot bot commented Aug 1, 2024 •

edited

Loading