Skip to content

Remove wget call to builder install_cuda.sh#132410

Closed
atalman wants to merge 1 commit intopytorch:mainfrom
atalman:remove_docker_install_cuda
Closed

Remove wget call to builder install_cuda.sh#132410
atalman wants to merge 1 commit intopytorch:mainfrom
atalman:remove_docker_install_cuda

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Aug 1, 2024 •
edited
Loading

This file install_cuda.sh now lives in .ci/docker/common and will be removed from builder repo.
Here is PR that removes it from builder: pytorch/builder#1949

@atalman atalman requested a review from jeffdaily as a code owner August 1, 2024 14:22
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132410

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 24f7677 with merge base f4f7aba (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 1, 2024
@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Aug 1, 2024

@pytorchmergebot merge -f "lint and docker builds are successful"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 1, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman added a commit to atalman/pytorch that referenced this pull request Aug 13, 2024
@atalman
Remove wget call to builder install_cuda.sh (pytorch#132410)
c324d5d 
This file ``install_cuda.sh`` now lives in ``.ci/docker/common`` and will be removed from builder repo.
Here is PR that removes it from builder: pytorch/builder#1949
Pull Request resolved: pytorch#132410
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atalman @pytorchmergebot @Skylion007