Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132138
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
left a comment
There was a problem hiding this comment.
Do we want ciflow/binaries to make sure nothing weird still depend on these?
Otherwise sounds good
huydhn
left a comment
There was a problem hiding this comment.
LGTM! As ExecuTorch build doesn't work with 3.8, we can ping ExecuTorch folks about this and pytorch/test-infra#5517 so that they don't need to figure out a way to support that version anymore (cc @guangy10 @dbort)
Thanks for pointing this out. I was actually looking at implementing matrix without 3.8 for ET. |
|
@pytorchmergebot merge -f "lint sanity check is expected" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007 (cherry picked from commit 40f80a7)
Fix lint (#137023) By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by #132138 Pull Request resolved: #137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007 (cherry picked from commit 40f80a7) Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
By migrating some of the workflows to Python-3.9 as 3.8 has been deprecated by pytorch#132138 Pull Request resolved: pytorch#137023 Approved by: https://github.com/ZainRizvi, https://github.com/janeyx99, https://github.com/seemethere, https://github.com/kit1980, https://github.com/Skylion007
Removing python 3.8 support in nightly builds. As per PR: #120718