[Caffe2] Refactoring MIOpen activation ops#13187
Closed
ashishfarmer wants to merge 10 commits intopytorch:masterfrom
Closed
[Caffe2] Refactoring MIOpen activation ops#13187ashishfarmer wants to merge 10 commits intopytorch:masterfrom
ashishfarmer wants to merge 10 commits intopytorch:masterfrom
Conversation
added 10 commits
October 26, 2018 14:27
Author
bddppq
reviewed
Oct 26, 2018
Contributor
bddppq
left a comment
There was a problem hiding this comment.
Nice work. Could you add some tests in caffe2/python/operator_tests?
Author
|
The activation_ops_test.py and hyperbolic_ops_test.py already has tests for the changes in this PR. Because of the cudnn aliasing, we did not need to update anything in the python tests |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bddppq
approved these changes
Oct 27, 2018
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 27, 2018
Summary: This pull request contains changes for: 1. Adding a generalized MIOpen activation class to be used by activation operators 2. Refactoring MIOpen ReLU op to use the new class 3. Adding ELU, Tanh and Sigmoid MIOpen ops Differential Revision: D12810112 Pulled By: bddppq fbshipit-source-id: 9519b3a0cd733b906bcba5d8948be089029c43ac
Contributor
|
Landed |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This pull request contains changes for: 1. Adding a generalized MIOpen activation class to be used by activation operators 2. Refactoring MIOpen ReLU op to use the new class 3. Adding ELU, Tanh and Sigmoid MIOpen ops Differential Revision: D12810112 Pulled By: bddppq fbshipit-source-id: 9519b3a0cd733b906bcba5d8948be089029c43ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains changes for:
cc: @bddppq