Fix move constructor on c10d::CUDAEvent#13183
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Previously, the move constructor performed a swap between the item being moved in, and the uninitialized garbage from the object itself. I didn't bother adding a test because I shortly intend to kill this class entirely. But the fix is so easy that I wanted to put it in in case I don't get around to doing this. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pietern
approved these changes
Oct 26, 2018
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Previously, the move constructor performed a swap between the item being moved in, and the uninitialized garbage from the object itself. I didn't bother adding a test because I shortly intend to kill this class entirely. But the fix is so easy that I wanted to put it in in case I don't get around to doing this. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#13183 Reviewed By: pietern Differential Revision: D12809062 Pulled By: ezyang fbshipit-source-id: 0d94bb9796fb7d30621256bfb401a4f89ba8ddc8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the move constructor performed a swap
between the item being moved in, and the uninitialized
garbage from the object itself.
I didn't bother adding a test because I shortly intend
to kill this class entirely. But the fix is so easy that
I wanted to put it in in case I don't get around to doing
this.
Signed-off-by: Edward Z. Yang ezyang@fb.com