Closed
Conversation
[ghstack-poisoned]
This was referenced Jul 24, 2024
Closed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/131712
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit d14484c with merge base f389bca ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
drisspg
added a commit
to drisspg/pytorch
that referenced
this pull request
Jul 25, 2024
ghstack-source-id: cdfdb9a Pull Request resolved: pytorch#131712
jainapurva
approved these changes
Jul 25, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Collaborator
|
@drisspg Now that the CUTLASS upgrade is merged in, might be time to rebase and update flash attention. :) |
Contributor
Author
|
@Skylion007 Ahh sweet thanks for the ping, I will rebase |
Skylion007
reviewed
Aug 16, 2024
| # Suspect users building from source will need this | ||
| add_definitions(-DFLASHATTENTION_DISABLE_ALIBI) | ||
| # Same for softcapping | ||
| add_definitions(-FLASHATTENTION_DISABLE_SOFTCAP) |
Collaborator
There was a problem hiding this comment.
Suggested change
| add_definitions(-FLASHATTENTION_DISABLE_SOFTCAP) | |
| add_definitions(-DFLASHATTENTION_DISABLE_SOFTCAP) |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):