Skip to content

Fix broken master#13171

Closed
li-roy wants to merge 1 commit intopytorch:masterfrom
li-roy:dtypefix
Closed

Fix broken master#13171
li-roy wants to merge 1 commit intopytorch:masterfrom
li-roy:dtypefix

Conversation

@li-roy
Copy link
Copy Markdown
Contributor

@li-roy li-roy commented Oct 26, 2018

Fixes colliding changes in #12766 and #12368

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

// for half inputs, save_mean, save_invstd are float (ideally, we would cast
// everything else, but not now)
auto mu = unsqueeze_dim1(training ? save_mean.to(input.dtype()) : running_mean, input);
auto mu = unsqueeze_dim1(training ? save_mean.to(input) : running_mean, input);

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve in interest in unblocking. However, @li-roy, I think to(input.dtype()) should still work.

@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Fixes colliding changes in pytorch#12766 and pytorch#12368
Pull Request resolved: pytorch#13171

Differential Revision: D12109430

Pulled By: li-roy

fbshipit-source-id: f068c7df227d920aa3840762e892ce6e9c109237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants