Remove python_default_init completely from ATen and Codegen#13149
Closed
wanchaol wants to merge 2 commits intopytorch:masterfrom
Closed
Remove python_default_init completely from ATen and Codegen#13149wanchaol wants to merge 2 commits intopytorch:masterfrom
wanchaol wants to merge 2 commits intopytorch:masterfrom
Conversation
89198c7 to
a2cc6d3
Compare
ssnl
reviewed
Nov 5, 2018
aten/src/ATen/native/SpectralOps.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/Declarations.cwrap
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zdevito
reviewed
Nov 5, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
06f7c7c to
182c1fe
Compare
182c1fe to
dce8a26
Compare
Collaborator
Author
|
close this in favor of #15234 |
jspark1105
pushed a commit
to jspark1105/pytorch
that referenced
this pull request
Dec 20, 2018
Summary: Optional clean up. This PR remove python_default_init from the yaml files, and the code-gen, and utilize optional type to do the work. This also fix the bug in the pytorch#13149 to correctly adopt as_strided backward. Fixes pytorch#9941 Pull Request resolved: pytorch#15234 Differential Revision: D13502044 Pulled By: wanchaol fbshipit-source-id: 774b61fc4414482cf11d56e22bd0275aefb352a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #12582 , it removes python_default_init completely from ATen and the codegen, and utilize our c10::optional if possible.