Skip to content

Hipify caffe2/core#13148

Closed
bddppq wants to merge 3 commits intopytorch:masterfrom
bddppq:hipify-caffe2-core
Closed

Hipify caffe2/core#13148
bddppq wants to merge 3 commits intopytorch:masterfrom
bddppq:hipify-caffe2-core

Conversation

@bddppq
Copy link
Copy Markdown
Contributor

@bddppq bddppq commented Oct 25, 2018 •
edited
Loading

@bddppq bddppq force-pushed the hipify-caffe2-core branch 2 times, most recently from 8ef1d35 to 41f89b2 Compare October 25, 2018 23:19
@bddppq
Copy link
Copy Markdown
Contributor Author

bddppq commented Oct 25, 2018 •
edited
Loading

triggered tests
https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-clang7-rocmdeb-ubuntu16.04-trigger-test/3609/
https://ci.pytorch.org/jenkins/job/pytorch-builds/job/py2-clang7-rocmdeb-ubuntu16.04-trigger/3460/

facebook-github-bot
facebook-github-bot reviewed Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@petrex
Copy link
Copy Markdown
Contributor

petrex commented Oct 25, 2018

thanks @bddppq
Just want to make sure we are able to get pre-hipified files back when we need them; for platform-specific optimization/tweaking.

@bddppq
Copy link
Copy Markdown
Contributor Author

bddppq commented Oct 25, 2018

@petrex Yes the build infra is still there. When we need special logic (so far we don't have any) we can add it back by simply dropping the file to caffe2/core and add an exclude rule in the hipify script.

@bddppq
Copy link
Copy Markdown
Contributor Author

bddppq commented Oct 26, 2018

@pytorchbot test this please

facebook-github-bot
facebook-github-bot reviewed Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq requested a review from ezyang October 26, 2018 00:14
@bddppq bddppq added the module: rocm AMD GPU support for Pytorch label Oct 26, 2018
@yf225
Copy link
Copy Markdown
Contributor

yf225 commented Oct 26, 2018

@pytorchbot retest this please

@bddppq bddppq force-pushed the hipify-caffe2-core branch from 9bbbd9f to 94b57fe Compare October 26, 2018 15:35
@bddppq bddppq mentioned this pull request Oct 26, 2018
Closed
@bddppq bddppq force-pushed the hipify-caffe2-core branch from 9df569b to 813a08f Compare October 26, 2018 18:40
facebook-github-bot
facebook-github-bot reviewed Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 26, 2018
@bddppq @facebook-github-bot
Hipify caffe2/core (#13148)
ee52b50 
Summary:
petrex ashishfarmer iotamudelta
Pull Request resolved: pytorch/pytorch#13148

Reviewed By: xw285cornell

Differential Revision: D10862276

Pulled By: bddppq

fbshipit-source-id: 1754834ec50f7dd2f752780e20b2a9cf19d03fc4
@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@bddppq @facebook-github-bot
Hipify caffe2/core (pytorch#13148)
b8392e3 
Summary:
petrex ashishfarmer iotamudelta
Pull Request resolved: pytorch#13148

Reviewed By: xw285cornell

Differential Revision: D10862276

Pulled By: bddppq

fbshipit-source-id: 1754834ec50f7dd2f752780e20b2a9cf19d03fc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang Awaiting requested review from ezyang

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: rocm AMD GPU support for Pytorch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bddppq @petrex @yf225 @facebook-github-bot @ezyang