Skip to content

CMake integration for Int8 ops#13145

Closed
Maratyszcza wants to merge 1 commit intopytorch:masterfrom
Maratyszcza:int8-ops
Closed

CMake integration for Int8 ops#13145
Maratyszcza wants to merge 1 commit intopytorch:masterfrom
Maratyszcza:int8-ops

Conversation

@Maratyszcza
Copy link
Copy Markdown
Contributor

@Maratyszcza Maratyszcza commented Oct 25, 2018

No description provided.

facebook-github-bot
facebook-github-bot reviewed Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maratyszcza has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

orionr
orionr reviewed Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few requests, but looks good.

Comment thread setup.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread CMakeLists.txt Outdated
Comment thread caffe2/operators/quantized/CMakeLists.txt Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread caffe2/operators/quantized/CMakeLists.txt Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread tools/build_pytorch_libs.bat Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread tools/build_pytorch_libs.bat Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread tools/build_pytorch_libs.sh Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maratyszcza has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

orionr
orionr approved these changes Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last request, but looks good.

Comment thread setup.py Outdated

This comment was marked as off-topic.

Sign in to view

Yangqing
Yangqing suggested changes Oct 26, 2018
View reviewed changes
Comment thread caffe2/operators/quantized/CMakeLists.txt Outdated
facebook-github-bot
facebook-github-bot reviewed Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maratyszcza has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225
Copy link
Copy Markdown
Contributor

yf225 commented Oct 26, 2018

@pytorchbot retest this please

Yangqing
Yangqing approved these changes Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@Yangqing Yangqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zdevito pushed a commit to zdevito/ATen that referenced this pull request Oct 26, 2018
@facebook-github-bot
CMake integration for Int8 ops
392a1d4 
Summary: Pull Request resolved: pytorch/pytorch#13145

Differential Revision: D10860849

Pulled By: Maratyszcza

fbshipit-source-id: fdbcc23ff9beaeaedfd561176df6cfe87685c1f5
@colesbury
Copy link
Copy Markdown
Member

colesbury commented Oct 26, 2018 •
edited
Loading

@Maratyszcza, this seems to break GCC 4.8 source builds. Would you please fix it or back out the change?

(I think we may be missing GCC 4.8 in the contbuild)

EDIT: I just forgot to run git submodule update --init

@Maratyszcza Maratyszcza deleted the int8-ops branch December 8, 2018 12:28
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
CMake integration for Int8 ops
9f6b013 
Summary: Pull Request resolved: pytorch#13145

Differential Revision: D10860849

Pulled By: Maratyszcza

fbshipit-source-id: fdbcc23ff9beaeaedfd561176df6cfe87685c1f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith Awaiting requested review from soumith

@harouwu harouwu Awaiting requested review from harouwu

@gchanan gchanan Awaiting requested review from gchanan

@colesbury colesbury Awaiting requested review from colesbury

@zdevito zdevito Awaiting requested review from zdevito

3 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@orionr orionr orionr approved these changes

@Yangqing Yangqing Yangqing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Maratyszcza @yf225 @colesbury @orionr @Yangqing @facebook-github-bot @ezyang