Use CAFFE_ENFORCE instead of CHECK in caffe2 rnn executor#13144
Closed
ilia-cher wants to merge 1 commit intopytorch:masterfrom
Closed
Use CAFFE_ENFORCE instead of CHECK in caffe2 rnn executor#13144ilia-cher wants to merge 1 commit intopytorch:masterfrom
ilia-cher wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: The intention of this diff is to prevent prevent predictor service from crashing by the "Check failed: timestep >= 0 && timestep < _T" error, as a bandage, before D10848803 can be landed (assuming D10848803 replaces the CHECKs into CAFFE_ENFORCEs, too). Differential Revision: D10857963 fbshipit-source-id: 896db804a89960e8d49f0434723515035062e0cc
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: Pull Request resolved: pytorch#13144 The intention of this diff is to prevent prevent predictor service from crashing by the "Check failed: timestep >= 0 && timestep < _T" error, as a bandage, before D10848803 can be landed (assuming D10848803 replaces the CHECKs into CAFFE_ENFORCEs, too). Reviewed By: ilia-cher Differential Revision: D10857963 fbshipit-source-id: bb56ad83aa867a2d25953aa7ffd84b078f8bf84a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use CAFFE_ENFORCE instead of CHECK when validating inputs in RNN executor