Skip to content

Disable upsample optest#13135

Closed
zrphercule wants to merge 6 commits intopytorch:masterfrom
zrphercule:disable_upsample_optest
Closed

Disable upsample optest#13135
zrphercule wants to merge 6 commits intopytorch:masterfrom
zrphercule:disable_upsample_optest

Conversation

@zrphercule
Copy link
Copy Markdown
Contributor

Temporarily disable upsample tests.

@zrphercule zrphercule requested a review from houseroad October 25, 2018 18:51
@zrphercule
Copy link
Copy Markdown
Contributor Author

@houseroad could you please give a stamp? Thanks!

Comment thread test/onnx/test_operators.py Outdated
# TODO(Rui Zhu): Enable upsample_op test by fixing the number of input.
# See https://github.com/onnx/onnx/pull/1467/files
#
# def test_upsample(self):

This comment was marked as off-topic.

@houseroad
Copy link
Copy Markdown
Member

To unblock onnx/onnx#1467

@zrphercule
Copy link
Copy Markdown
Contributor Author

@houseroad done

Comment thread test/onnx/test_operators.py Outdated

class TestOperators(TestCase):

def skipAlwaysForCI(func):

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Copy Markdown
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, if CI is green, just land it

@houseroad
Copy link
Copy Markdown
Member

import?

@zrphercule
Copy link
Copy Markdown
Contributor Author

@houseroad sure.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zrphercule zrphercule deleted the disable_upsample_optest branch October 26, 2018 04:58
@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Temporarily disable upsample tests.
Pull Request resolved: pytorch#13135

Reviewed By: bddppq

Differential Revision: D10859926

Pulled By: houseroad

fbshipit-source-id: 9eb068198d43ba0939d81a9e41eb6f24ff19cb6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants