bring caffe2::Tensor API closer to aten/pytorch#13134
Closed
jerryzh168 wants to merge 1 commit intopytorch:masterfrom
Closed
bring caffe2::Tensor API closer to aten/pytorch#13134jerryzh168 wants to merge 1 commit intopytorch:masterfrom
jerryzh168 wants to merge 1 commit intopytorch:masterfrom
Conversation
8d4c426 to
a8f32ae
Compare
a8f32ae to
66a790b
Compare
Summary: Pull Request resolved: pytorch#13134 For tensor, we plan to do the following renaming: ``` * t.ndim() → t.dim() * t.size() → t.numel() * dims() → t.sizes() * t.meta() → t.dtype() * t.dim(d) → t.size(d) ``` This diff adds new APIs in caffe2::Tensor so we can start codemod, we'll remove old API after the codemod Reviewed By: ezyang Differential Revision: D10856028 fbshipit-source-id: 117bbdc649b09d9f7d78dfb27522a641241c41eb
66a790b to
e3da9d8
Compare
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13134 For tensor, we plan to do the following renaming: ``` * t.ndim() → t.dim() * t.size() → t.numel() * dims() → t.sizes() * t.meta() → t.dtype() * t.dim(d) → t.size(d) ``` This diff adds new APIs in caffe2::Tensor so we can start codemod, we'll remove old API after the codemod Reviewed By: ezyang Differential Revision: D10856028 fbshipit-source-id: 1638997e234d7b3113ef8be65a16246f902273c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For tensor, we plan to do the following renaming:
This diff adds new APIs in caffe2::Tensor so we can start codemod,
we'll remove old API after the codemod
Reviewed By: ezyang
Differential Revision: D10856028