Change explicit usages of at::optional to c10::optional#13082
Closed
dzhulgakov wants to merge 2 commits intopytorch:masterfrom
Closed
Change explicit usages of at::optional to c10::optional#13082dzhulgakov wants to merge 2 commits intopytorch:masterfrom
dzhulgakov wants to merge 2 commits intopytorch:masterfrom
Conversation
ezyang
approved these changes
Oct 24, 2018
added 2 commits
October 25, 2018 09:57
Summary: Pull Request resolved: pytorch#12991 Previous commit missed a file in test/cpp, which did not have a fbcode internal target and slipped off contbuild. Will export to oss and ensure that things build this time. Differential Revision: D10511254 fbshipit-source-id: bce31627ae4f7ad452079acf480bd66b88f38634
Summary: Pull Request resolved: pytorch#13082 Follow up of D10511254. For these cases we can move to preferred `optional` without namespace right away. Reviewed By: ezyang, Yangqing Differential Revision: D10844117 fbshipit-source-id: b9cde69826727824b7b2a5a1b4387744fbd2569e
b752713 to
1eaa0dd
Compare
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13082 Follow up of D10511254. For these cases we can move to preferred `optional` without namespace right away. Reviewed By: ezyang, Yangqing Differential Revision: D10844117 fbshipit-source-id: 99a59e692fb4b236b299579f937f1536d443d899
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Follow up of D10511254. For these cases we can move to preferred
optionalwithout namespace right away.Differential Revision: D10844117