[jit] improve constants error message#13072
Closed
driazati wants to merge 2 commits intopytorch:masterfrom
driazati:cerr
Closed
[jit] improve constants error message#13072driazati wants to merge 2 commits intopytorch:masterfrom driazati:cerr
driazati wants to merge 2 commits intopytorch:masterfrom
driazati:cerr
Conversation
Adds the attribute name to the error message and fixes the corresponding test to actually run
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
suo
approved these changes
Oct 25, 2018
| with tester.assertRaisesRegex(TypeError, "not a valid constant"): | ||
| self.i = (3, 4, {}) | ||
|
|
||
| f = Foo() |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2018
Summary: Depends on #13072 Adds support for tuples as variables instead of just as literals. Before, tuples would give the error `python value of type 'tuple' cannot be used as a value`. This PR adds a flag on `SugaredValue` to determine in a value is a tuple or not. Pull Request resolved: #13086 Differential Revision: D10846632 Pulled By: driazati fbshipit-source-id: 7b5d6ae9426ca3dd476fee3f929357d7b180faa7
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Adds the attribute name to the error message and fixes the corresponding test to actually run Pull Request resolved: pytorch#13072 Differential Revision: D10846622 Pulled By: driazati fbshipit-source-id: a7eee6320c28140c4937ede3d4e4685cfce08d84
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Depends on pytorch#13072 Adds support for tuples as variables instead of just as literals. Before, tuples would give the error `python value of type 'tuple' cannot be used as a value`. This PR adds a flag on `SugaredValue` to determine in a value is a tuple or not. Pull Request resolved: pytorch#13086 Differential Revision: D10846632 Pulled By: driazati fbshipit-source-id: 7b5d6ae9426ca3dd476fee3f929357d7b180faa7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the attribute name to the error message and fixes the corresponding
test to actually run