Skip to content

[TEST][Inductor] Fix scaled_mm call#130582

Closed
Aidyn-A wants to merge 1 commit intopytorch:mainfrom
Aidyn-A:test_inductor_fix_scaled_mm_call
Closed

[TEST][Inductor] Fix scaled_mm call#130582
Aidyn-A wants to merge 1 commit intopytorch:mainfrom
Aidyn-A:test_inductor_fix_scaled_mm_call

Conversation

@Aidyn-A
Copy link
Collaborator

@Aidyn-A Aidyn-A commented Jul 11, 2024

@Aidyn-A Aidyn-A requested a review from drisspg July 11, 2024 23:06
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130582

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1623813 with merge base a833582 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch thanks!

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jul 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jul 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jul 22, 2024
… cases (#130868)

Continuing #128683 and #130582.

The api of _scaled_mm has changed. For example, there is only one return now. So change the aoti api as well.

Also, tested the fp8 tests offline. The test_fp8_abi_compatible_cpu_with_stack_allocation_and_minimal_arrayref_interface would fail with `error: use of undeclared identifier 'float8_e4m3fn'` and `error: use of undeclared identifier 'half'`, so skipping them for now.

The reason this wasn't known earlier is probably because the CI doesn't use H100.

Pull Request resolved: #130868
Approved by: https://github.com/drisspg, https://github.com/chenyang78, https://github.com/desertfire
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
`_scaled_mm` no longer returns `amax` (see pytorch#128683)

Pull Request resolved: pytorch#130582
Approved by: https://github.com/drisspg
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
… cases (pytorch#130868)

Continuing pytorch#128683 and pytorch#130582.

The api of _scaled_mm has changed. For example, there is only one return now. So change the aoti api as well.

Also, tested the fp8 tests offline. The test_fp8_abi_compatible_cpu_with_stack_allocation_and_minimal_arrayref_interface would fail with `error: use of undeclared identifier 'float8_e4m3fn'` and `error: use of undeclared identifier 'half'`, so skipping them for now.

The reason this wasn't known earlier is probably because the CI doesn't use H100.

Pull Request resolved: pytorch#130868
Approved by: https://github.com/drisspg, https://github.com/chenyang78, https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants