[ROCm] Enable test_nn embedding tests and use correct warp size in Embedding.cu#13046
Closed
iotamudelta wants to merge 1 commit intopytorch:masterfrom
Closed
[ROCm] Enable test_nn embedding tests and use correct warp size in Embedding.cu#13046iotamudelta wants to merge 1 commit intopytorch:masterfrom
iotamudelta wants to merge 1 commit intopytorch:masterfrom
Conversation
….cu (ROCm 285) * Enable test_nn embedding tests and use correct warp size in Embedding.cu * Fix embedding_backward_feature_kernel kernel for HIP
Contributor
Author
soumith
approved these changes
Oct 24, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 25, 2018
….cu (#13046) Summary: * Enable test_nn embedding tests and use correct warp size in Embedding.cu * Fix embedding_backward_feature_kernel kernel for HIP For attention: bddppq ezyang Pull Request resolved: pytorch/pytorch#13046 Differential Revision: D10560721 Pulled By: bddppq fbshipit-source-id: e6c3cbeb980a34ff52a92dba8bde745a2e03f2fd
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
….cu (pytorch#13046) Summary: * Enable test_nn embedding tests and use correct warp size in Embedding.cu * Fix embedding_backward_feature_kernel kernel for HIP For attention: bddppq ezyang Pull Request resolved: pytorch#13046 Differential Revision: D10560721 Pulled By: bddppq fbshipit-source-id: e6c3cbeb980a34ff52a92dba8bde745a2e03f2fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For attention: @bddppq @ezyang