Skip to content

add topology index check in Graph::lint()#13037

Closed
suo wants to merge 2 commits intomasterfrom
suo/topo-lint
Closed

add topology index check in Graph::lint()#13037
suo wants to merge 2 commits intomasterfrom
suo/topo-lint

Conversation

@suo
Copy link
Copy Markdown
Member

@suo suo commented Oct 24, 2018

just a sanity check to make sure everything is in order

@suo suo added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 24, 2018
@suo suo requested a review from zdevito October 24, 2018 08:00
@suo suo force-pushed the suo/topo-lint branch 2 times, most recently from 3182597 to af503d3 Compare October 24, 2018 21:41
@suo suo assigned suo and zdevito and unassigned suo Oct 25, 2018
Comment thread torch/csrc/jit/ir.cpp Outdated
}
void check_block(const Block *b) {
// Check topological ordering
JIT_ASSERT(b->input_->isBefore(*b->nodes().begin()));

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

michaelsuo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@suo suo deleted the suo/topo-lint branch October 26, 2018 00:04
@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
just a sanity check to make sure everything is in order
Pull Request resolved: pytorch#13037

Differential Revision: D10854563

Pulled By: michaelsuo

fbshipit-source-id: 409303c4cbf058b75e24bf2213b49e9d79cb862e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants