Skip to content

Update torch-xpu-ops pin (ATen XPU implementation)#130333

Closed
fengyuan14 wants to merge 3 commits intomainfrom
fy/update-xpu
Closed

Update torch-xpu-ops pin (ATen XPU implementation)#130333
fengyuan14 wants to merge 3 commits intomainfrom
fy/update-xpu

Conversation

@fengyuan14
Copy link
Copy Markdown
Collaborator

@fengyuan14 fengyuan14 commented Jul 9, 2024

  1. Fixing compilation error due to PyTorch update. The helper function prototype changes, checkIndexTensorTypes.
  2. Fixing compilation error due to PyTorch update. PyTorch forced -Werror=unused-function.
  3. Fixing inductor case failure due to CUDA bias implementation in the case. [Break XPU] The newly added test_cond_control_flow_with_precomputed_size use requires_gpu, but hard code cuda. #130426

cc @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @gujinghui @guangyey

@fengyuan14 fengyuan14 added open source module: intel Specific to x86 architecture ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel ciflow/xpu Run XPU CI tasks module: xpu Intel XPU related issues labels Jul 9, 2024
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jul 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130333

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5a97615 with merge base 71efbf7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Fixing break building issue due to PyTorch update. The helper function prototype changes, `checkIndexTensorTypes`.

Signed-off-by: Feng Yuan <feng1.yuan@intel.com>
@fengyuan14
Copy link
Copy Markdown
Collaborator Author

We have to couple torch-xpu-ops pin update and inductor case fixing in a PR, since they block each other in PyTorch pre-ci.

@EikanWang EikanWang requested review from desertfire and jansel July 10, 2024 13:48
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chuanqi129
Copy link
Copy Markdown
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
1. Fixing compilation error due to PyTorch update. The helper function prototype changes, `checkIndexTensorTypes`.
2. Fixing compilation error due to PyTorch update. PyTorch forced -Werror=unused-function.
3. Fixing inductor case failure due to CUDA bias implementation in the case. pytorch#130426

Pull Request resolved: pytorch#130333
Approved by: https://github.com/EikanWang, https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks intel This tag is for PR from Intel Merged module: inductor module: intel Specific to x86 architecture module: xpu Intel XPU related issues open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants