Skip to content

[pt1][tensor] Change the function signature for caffe2::empty#13015

Closed
jerryzh168 wants to merge 3 commits intomasterfrom
export-D10469310
Closed

[pt1][tensor] Change the function signature for caffe2::empty#13015
jerryzh168 wants to merge 3 commits intomasterfrom
export-D10469310

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented Oct 23, 2018

Stack:
    :black_circle:  #13015 [pt1][tensor] Change the function signature for caffe2::empty  💚

att

Differential Revision: D10469310

Differential Revision: D10371541
Differential Version: 61433186
Differential Revision: D10469310
Differential Version: 61453210
Comment thread caffe2/core/blob.h
<< " dims: " << dims;
// << " options: " << options; (operator<< for Options is in at:: now)
return blob->Reset<Tensor>(new Tensor(empty(dims, options)));
return blob->Reset<Tensor>(new Tensor(caffe2::empty(dims, options)));

This comment was marked as off-topic.

This comment was marked as off-topic.

Comment thread caffe2/core/operator.h Outdated
return outputs_.at(idx);
}

// Check whether output j is an alias of input i

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted with comments.

Differential Revision: D10469310
Differential Version: 61542739
@jerryzh168 jerryzh168 changed the base branch from export-D10371541 to master October 24, 2018 19:09
@soumith soumith deleted the export-D10469310 branch February 21, 2019 23:24
@ezyang ezyang added the merged label Jun 25, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#13015

att

Reviewed By: ezyang

Differential Revision: D10469310

fbshipit-source-id: f4621fe5d17bb4663192860f81effe6bdfe21bea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants