Use GetFetchStackTrace for the AT_* error macros too.#13007
Closed
Use GetFetchStackTrace for the AT_* error macros too.#13007
Conversation
Differential Revision: D10518499 Differential Version: 61450239
Differential Revision: D10518499 Differential Version: 61450706
Yangqing
approved these changes
Oct 23, 2018
Contributor
Author
|
Hmm, I wonder why this regex is failing. Looks OK to me. |
Differential Revision: D10518499 Differential Version: 61514037
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13007 No reason to use the hook if it's set, this helps fbcode traces. This slightly pessimizes the stack trace for ATen functions, because we are no longer skipping all of the frames we should. This is probably OK. Reviewed By: Yangqing Differential Revision: D10518499 fbshipit-source-id: be54e490df3c3fde7ff894b5b1473442ffc7ded3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #13007 Use GetFetchStackTrace for the AT_ error macros too.* 💚
No reason to use the hook if it's set, this helps fbcode traces.
This slightly pessimizes the stack trace for ATen functions,
because we are no longer skipping all of the frames we should.
This is probably OK.
Differential Revision: D10518499