Native wrappers for many Declarations.cwrap entries#13003
Closed
gchanan wants to merge 11 commits intopytorch:masterfrom
Closed
Native wrappers for many Declarations.cwrap entries#13003gchanan wants to merge 11 commits intopytorch:masterfrom
gchanan wants to merge 11 commits intopytorch:masterfrom
Conversation
The goal here is to have wrappers specified for everything in Declarations.cwrap, then eliminate Declarations.cwrap (check in the generated code).
…ill do the DeviceGuard. This is just temporary, as we should do the standard device guard here and remove it from TH wrapping, but that will come later.
Contributor
Author
|
Note this is stacked on #12943; to review look at https://github.com/pytorch/pytorch/pull/13003/files/f562df2bfbc6fa8a444372a461621e10cddd0be4..HEAD. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Oct 25, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 27, 2018
Summary: Pull Request resolved: pytorch/pytorch#13003 Differential Revision: D10515654 Pulled By: gchanan fbshipit-source-id: c3f2809fdb7daeea2209ef1bcdea60266dc4854d
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#13003 Differential Revision: D10515654 Pulled By: gchanan fbshipit-source-id: c3f2809fdb7daeea2209ef1bcdea60266dc4854d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.