[build] Move a number of ATen checks out of Dependencies.cmake#12990
Closed
orionr wants to merge 3 commits intopytorch:masterfrom
Closed
[build] Move a number of ATen checks out of Dependencies.cmake#12990orionr wants to merge 3 commits intopytorch:masterfrom
orionr wants to merge 3 commits intopytorch:masterfrom
Conversation
Yangqing
reviewed
Oct 23, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
Thanks! One nit commit and the rest looks good. |
Contributor
Author
|
Build timeouts on a few, but otherwise looks good. |
soumith
approved these changes
Oct 25, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 26, 2018
Summary: cc Yangqing mingzhe09088 anderspapitto mingzhe09088 Pull Request resolved: pytorch/pytorch#12990 Differential Revision: D10862301 Pulled By: orionr fbshipit-source-id: 62ba09cf0725f29692fac71bc30173469283390b
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: cc Yangqing mingzhe09088 anderspapitto mingzhe09088 Pull Request resolved: pytorch#12990 Differential Revision: D10862301 Pulled By: orionr fbshipit-source-id: 62ba09cf0725f29692fac71bc30173469283390b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Yangqing @mingzhe09088 @anderspapitto @mingzhe09088